-
Notifications
You must be signed in to change notification settings - Fork 733
Backport bump of System.Configuration.ConfigurationManager and System.Threading.Tasks.Extensions
#2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jnyrup
merged 3 commits into
fluentassertions:main
from
jnyrup:jn/backport_configuration_manager
Nov 30, 2024
Merged
Backport bump of System.Configuration.ConfigurationManager and System.Threading.Tasks.Extensions
#2856
jnyrup
merged 3 commits into
fluentassertions:main
from
jnyrup:jn/backport_configuration_manager
Nov 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluentassertions#2673 bumped from 4.4.0 -> 6.0.1, but 6.0.0 should be enough. As a testing nuget we should pick the lowest possible version of a package to avoid that tests use a newer package than what is used in production.
System.Configuration.ConfigurationManager and System.Threading.Tasks.Extensions
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Pull Request Test Coverage Report for Build 12096767877Details
💛 - Coveralls |
dennisdoomen
approved these changes
Nov 30, 2024
This was referenced Jul 21, 2025
This was referenced Jul 29, 2025
This was referenced Dec 8, 2025
Open
This was referenced Dec 15, 2025
This was referenced Dec 23, 2025
This was referenced Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2673 and #2855 to v7.
See those two PRs for detailed analyses.
CC: @ViktorHofer @AArnott @jacekmlynek
Since you've previously been involved in package vs framework references.
Additional details:
In #2122 (comment) I experimented with referencing 6.9.0 and 6.10.0 as nuget packages from a net47 project and then comparing detailed MSBuild logs.
It showed how 6.10.0 no longer had conflicts between package and framework assemblies.
Doing that same comparison between
mainand this PR, the MSBuild log is now down from 90 to 0 occurrences ofand now skips the running the build task
AddFacadesToReferencesComparing the


bin/folder of a net47 project that references Fluent Assertions via a nuget packages.main:
PR:

IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome