Skip to content

Conversation

@dennisdoomen
Copy link
Member

Drops support for .NET Core 2.1, 3.0 and NSpec, which are not supported by the community as well.

This will become version 7.0 and all bug fixes will land here. New features will go to 8.0.

@dennisdoomen dennisdoomen requested a review from jnyrup November 23, 2024 15:25
@github-actions
Copy link

github-actions bot commented Nov 23, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@dennisdoomen dennisdoomen force-pushed the drop-unsupported-frameworks branch 4 times, most recently from 15705a9 to 791b22e Compare November 23, 2024 16:39
@coveralls
Copy link

coveralls commented Nov 23, 2024

Pull Request Test Coverage Report for Build 11990146301

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 97.364%

Totals Coverage Status
Change from base Build 11987789599: 0.07%
Covered Lines: 12932
Relevant Lines: 13168

💛 - Coveralls

Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A historical note: The last time we removed support for a framework was in #1227 almost five years ago.
I hope people have upgraded their projects by now, since 2.1 and 3.0 went EOL on August 21, 2021 and December 13, 2022, respectively

@dennisdoomen
Copy link
Member Author

A historical note: The last time we removed support for a framework was in #1227 almost five years ago.
I hope people have upgraded their projects by now, since 2.1 and 3.0 went EOL on August 21, 2021 and December 13, 2022, respectively

Are you suggesting not to do this?

@dennisdoomen dennisdoomen force-pushed the drop-unsupported-frameworks branch from 791b22e to e1314d8 Compare November 23, 2024 19:20
@jnyrup
Copy link
Member

jnyrup commented Nov 23, 2024

A historical note: The last time we removed support for a framework was in #1227 almost five years ago.
I hope people have upgraded their projects by now, since 2.1 and 3.0 went EOL on August 21, 2021 and December 13, 2022, respectively

Are you suggesting not to do this?

Not at all, it was meant to show how supportive I think we've been for old/EOL frameworks.
I'm all for this PR 🚀

@dennisdoomen dennisdoomen force-pushed the drop-unsupported-frameworks branch from e1314d8 to 7c86ee5 Compare November 23, 2024 20:20
@dennisdoomen dennisdoomen enabled auto-merge (squash) November 25, 2024 06:03
@dennisdoomen dennisdoomen merged commit 5fa83e2 into fluentassertions:master Nov 25, 2024
5 checks passed
@dennisdoomen dennisdoomen deleted the drop-unsupported-frameworks branch November 25, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants