Skip to content

Allow event monitoring to ignore failing event accessors #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 17 commits into from
May 15, 2024
Merged

Allow event monitoring to ignore failing event accessors #2629

jnyrup merged 17 commits into from
May 15, 2024

Conversation

@ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Apr 22, 2024 •
edited
Loading

This finishes #1954

Closes #1948

Note: All credits goes to @apazureck!

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@ITaluone ITaluone changed the title Failing event accessors Allow event monitoring to ignore failing event accessors Apr 22, 2024
@github-actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@ITaluone ITaluone force-pushed the failing-event-accessors branch from 1bbac73 to 18ec177 Compare April 22, 2024 14:14
@coveralls
Copy link

coveralls commented Apr 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9099255757

Details

  • 36 of 36 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.566%
Totals Coverage Status
Change from base Build 9083182650: 0.005%
Covered Lines: 12054
Relevant Lines: 12238
💛 - Coveralls

@ITaluone ITaluone force-pushed the failing-event-accessors branch 2 times, most recently from e45626c to 030821c Compare April 22, 2024 14:36
dennisdoomen
dennisdoomen requested changes May 10, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking over the work. Just some minor comments to address.

@ITaluone ITaluone force-pushed the failing-event-accessors branch from 030821c to 1db0a61 Compare May 10, 2024 18:22
@ITaluone ITaluone requested a review from dennisdoomen May 10, 2024 18:23
@ITaluone ITaluone force-pushed the failing-event-accessors branch from 1db0a61 to 7544225 Compare May 10, 2024 18:26
@dennisdoomen dennisdoomen requested a review from jnyrup May 11, 2024 07:57
jnyrup
jnyrup reviewed May 15, 2024
View reviewed changes
@ITaluone ITaluone requested a review from jnyrup May 15, 2024 16:07
jnyrup
jnyrup reviewed May 15, 2024
View reviewed changes
@ITaluone ITaluone requested a review from jnyrup May 15, 2024 16:14
Andreas Pazureck and others added 14 commits May 15, 2024 18:17
@ITaluone
Removed event monitor builder
968a8f3 
Moved methods config options to `EventMonitorOptions`
@ITaluone
Removed unnecessary generic type from EventMonitorOptions
81334aa
@ITaluone
fixed build errors due to removing generic from options
b27873f
@ITaluone
Update api checks
d3c3bed
@apazureck @ITaluone
Update Src/FluentAssertions/Events/EventMonitorOptions.cs
6532f78 
Fixed wrong Timestamp
@ITaluone
Include reviewer feedback
5503796
@ITaluone
Added more reviewer suggestions.
47c0d24
@apazureck @jnyrup @ITaluone
Update Src/FluentAssertions/Events/EventMonitor.cs
8069817 
Co-authored-by: Jonas Nyrup <[email protected]>
@apazureck @jnyrup @ITaluone
Update Src/FluentAssertions/Events/EventMonitorOptions.cs
d95208e 
Co-authored-by: Jonas Nyrup <[email protected]>
@apazureck @ITaluone
- removed the exception when event recorder could not be removed from…
7d7fa07 
… the dictionary

- Added option to still receive events even when add accessor threw an exception
@jnyrup @ITaluone
cleanups
afe1814
@apazureck @ITaluone
Fixed Qodana complaints
8f10661
@apazureck @ITaluone
Removed boolean parameter and added method for recording events with …
1410992 
…broken accessor
@apazureck @ITaluone
Updated api tests for new RecordEventsWithBrokenAccessor method.
57555f0 
Updated descriptions to match current the actual behavior
This was referenced Dec 22, 2025
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Open
Closed
Closed
Merged
Closed
Open
Open
Closed
Closed
Closed
Open
Open
This was referenced Dec 29, 2025
Open
Merged
Merged
Merged
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

breaking change feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exceptions in event accessors fail tests when using .Monitor()

5 participants

@ITaluone @coveralls @dennisdoomen @jnyrup @apazureck