Skip to content

Make ThrowWithinAsync respect canceled tasks #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Mar 25, 2024
Merged

Make ThrowWithinAsync respect canceled tasks #2614

dennisdoomen merged 1 commit into from
Mar 25, 2024

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Mar 24, 2024

When the subject Task was canceled we did not recognize that.
Instead we got a non-faulting (but canceled) task when awaiting Task.WhenAny.

This fixes #2444

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Mar 24, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@coveralls
Copy link

coveralls commented Mar 24, 2024

Pull Request Test Coverage Report for Build 8410329534

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.557%
Totals Coverage Status
Change from base Build 8409735285: 0.0%
Covered Lines: 12005
Relevant Lines: 12189
💛 - Coveralls

@jnyrup jnyrup requested a review from dennisdoomen March 24, 2024 15:45
dennisdoomen
dennisdoomen approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dennisdoomen dennisdoomen merged commit dab540e into fluentassertions:develop Mar 25, 2024
@jnyrup jnyrup deleted the OperationCanceledException branch March 25, 2024 16:08
@jnyrup jnyrup added the bug label May 30, 2024
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@jnyrup
Make ThrowWithinAsync respect canceled tasks (fluentassertions#2614)
b279879
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@jnyrup
Make ThrowWithinAsync respect canceled tasks (fluentassertions#2614)
079dc0a
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@jnyrup
Make ThrowWithinAsync respect canceled tasks (fluentassertions#2614)
d837398
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@jnyrup
Make ThrowWithinAsync respect canceled tasks (fluentassertions#2614)
f4369c8
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@jnyrup
Make ThrowWithinAsync respect canceled tasks (fluentassertions#2614)
99073b6
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 24, 2024
@jnyrup
Make ThrowWithinAsync respect canceled tasks (fluentassertions#2614)
20bfa1a
jnyrup added a commit that referenced this pull request Sep 9, 2024
@jnyrup
Make ThrowWithinAsync respect canceled tasks (#2614)
f9b770b
@shuebner shuebner mentioned this pull request Nov 22, 2024
Closed
@jnyrup jnyrup mentioned this pull request Nov 30, 2024
Merged
7 tasks
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 1, 2025
Open
Closed
Closed
Open
Open
This was referenced Dec 8, 2025
Open
Merged
Open
Open
Closed
Closed
Open
Merged
Open
Closed
Closed
This was referenced Dec 21, 2025
Closed
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Open
Merged
Closed
Closed
Open
This was referenced Dec 29, 2025
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ThrowWithinAsync does not work with TaskCanceledException

3 participants

@jnyrup @coveralls @dennisdoomen