Skip to content

Correct null handling when using a custom comparer #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 15 commits into from
Dec 29, 2023
Merged

Correct null handling when using a custom comparer #2489

jnyrup merged 15 commits into from
Dec 29, 2023

Conversation

@MartinDemberger
Copy link
Contributor

@MartinDemberger MartinDemberger commented Nov 27, 2023

Currently a custom comparer surpresses the BeEquivalent compare with a nullable struct property against a expected null value.
This change doesn't use the custom comparer for a struct with a expected null.

#2480

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@MartinDemberger MartinDemberger marked this pull request as ready for review November 27, 2023 21:40
IT-VBFK
IT-VBFK reviewed Nov 27, 2023
View reviewed changes
IT-VBFK
IT-VBFK reviewed Nov 30, 2023
View reviewed changes
@MartinDemberger
Copy link
Contributor Author

MartinDemberger commented Dec 1, 2023

Can anyone help me? I don't understand the error message in Qodana.

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Dec 1, 2023

Try rebase at the current develop and push again

From my understanding, a qodana report without a summary (like here) happens, if the default branch (here develop) moves forward while the PR is not onto this branch.

@github-actions
Copy link

github-actions bot commented Dec 1, 2023 •
edited
Loading

Qodana for .NET

4 new problems were found

Inspection name Severity Problems
Possible 'System.NullReferenceException' 🔶 Warning 2
Auto-property accessor is never used (private accessibility) 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

dennisdoomen
dennisdoomen reviewed Dec 5, 2023
View reviewed changes
@dennisdoomen dennisdoomen changed the title Correct null handling when having a nullable struct propertywith a custom comparer Correct null handling when having a nullable struct property with a custom comparer Dec 9, 2023
@coveralls
Copy link

coveralls commented Dec 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7357619396

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 97.464%
Files with Coverage Reduction New Missed Lines %
Src/FluentAssertions/Execution/DefaultAssertionStrategy.cs 4 20.0%
Totals Coverage Status
Change from base Build 7260721275: 0.001%
Covered Lines: 11746
Relevant Lines: 11930
💛 - Coveralls

@dennisdoomen dennisdoomen requested a review from jnyrup December 11, 2023 17:44
@jnyrup jnyrup linked an issue Dec 12, 2023 that may be closed by this pull request
BeEquivalent failed with nullably struct property and EqualityComparer #2480
Closed
jnyrup
jnyrup reviewed Dec 12, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Qodana for .NET

58 new problems were found

Inspection name Severity Problems
Redundant type declaration body 🔶 Warning 51
Redundant using directive 🔶 Warning 7

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@ITaluone
Copy link
Contributor

ITaluone commented Dec 18, 2023

A few qodana issues are left :)

This was referenced Dec 8, 2025
Merged
Open
Open
Closed
Closed
Open
Merged
Open
Closed
Closed
This was referenced Dec 21, 2025
Closed
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Open
Merged
Closed
Closed
Open
This was referenced Dec 29, 2025
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

+2 more reviewers

@ITaluone ITaluone ITaluone left review comments

@IT-VBFK IT-VBFK IT-VBFK left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BeEquivalent failed with nullably struct property and EqualityComparer

7 participants

@MartinDemberger @IT-VBFK @coveralls @ITaluone @dennisdoomen @jnyrup @MartinDembergerR9