Skip to content

Improve failure message for NotBeOfType and BeReadable/BeWritable #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Oct 21, 2023
Merged

Improve failure message for NotBeOfType and BeReadable/BeWritable #2399

dennisdoomen merged 1 commit into from
Oct 21, 2023

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Oct 20, 2023

Inspired by #2398 I searched for more places where we don't guard continued assertions.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@jnyrup jnyrup mentioned this pull request Oct 20, 2023
Closed
@jnyrup jnyrup force-pushed the stop_asserting_when_wrapped branch from 7a36c29 to 500d81a Compare October 20, 2023 17:23
@coveralls
Copy link

coveralls commented Oct 20, 2023

Pull Request Test Coverage Report for Build 6590827297

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.4%
Totals Coverage Status
Change from base Build 6586600692: 0.003%
Covered Lines: 11665
Relevant Lines: 11856
💛 - Coveralls

dennisdoomen
dennisdoomen approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dennisdoomen dennisdoomen merged commit da130f2 into fluentassertions:develop Oct 21, 2023
@jnyrup jnyrup deleted the stop_asserting_when_wrapped branch October 22, 2023 15:10
@jnyrup jnyrup added the bug label Feb 11, 2024
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@jnyrup
Improve failure message for NotBeOfType and BeReadable/`BeWritabl…
7299c58 
…e` (fluentassertions#2399)
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@jnyrup
Improve failure message for NotBeOfType and BeReadable/`BeWritabl…
3a5caf5 
…e` (fluentassertions#2399)
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@jnyrup
Improve failure message for NotBeOfType and BeReadable/`BeWritabl…
65ac318 
…e` (fluentassertions#2399)
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@jnyrup
Improve failure message for NotBeOfType and BeReadable/`BeWritabl…
b8750dd 
…e` (fluentassertions#2399)
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@jnyrup
Improve failure message for NotBeOfType and BeReadable/`BeWritabl…
3c6a706 
…e` (fluentassertions#2399)
jnyrup added a commit that referenced this pull request Sep 9, 2024
@jnyrup
Improve failure message for NotBeOfType and BeReadable/`BeWritabl…
51f54ef 
…e` (#2399)
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 1, 2025
Open
Closed
Closed
Open
Open
Closed
Open
This was referenced Dec 8, 2025
Merged
Open
Open
Closed
Closed
Open
Merged
Open
Closed
Closed
This was referenced Dec 21, 2025
Closed
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Open
Merged
Closed
Closed
Open
This was referenced Dec 29, 2025
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnyrup @coveralls @dennisdoomen