Skip to content

Pass FormattingOptions to inner AssertionScope #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 3 commits into from
Oct 14, 2023
Merged

Pass FormattingOptions to inner AssertionScope #2329

dennisdoomen merged 3 commits into from
Oct 14, 2023

Conversation

@ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Sep 27, 2023 •
edited
Loading

Fixes #2170

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@coveralls
Copy link

coveralls commented Sep 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6517387718

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.402%
Totals Coverage Status
Change from base Build 6516441680: 0.0%
Covered Lines: 11650
Relevant Lines: 11841
💛 - Coveralls

@ITaluone ITaluone force-pushed the fix/respecting-formatting-options-in-inner-scope branch from eba65ab to 829a1e9 Compare September 27, 2023 11:01
@ITaluone
Copy link
Contributor Author

ITaluone commented Sep 28, 2023

Once #2318 is merged this qodana issue should be solved.

@ITaluone ITaluone force-pushed the fix/respecting-formatting-options-in-inner-scope branch 2 times, most recently from 6bd3f54 to cb01515 Compare September 29, 2023 08:43
jnyrup
jnyrup reviewed Sep 30, 2023
View reviewed changes
@ITaluone ITaluone force-pushed the fix/respecting-formatting-options-in-inner-scope branch 4 times, most recently from a64f85b to eaaad92 Compare October 1, 2023 18:26
@jnyrup jnyrup added the bug label Oct 1, 2023
@ITaluone ITaluone requested a review from jnyrup October 2, 2023 05:25
@jnyrup jnyrup requested a review from dennisdoomen October 2, 2023 15:59
@ITaluone ITaluone force-pushed the fix/respecting-formatting-options-in-inner-scope branch 2 times, most recently from bb334c2 to e544ed1 Compare October 5, 2023 07:24
@ITaluone ITaluone force-pushed the fix/respecting-formatting-options-in-inner-scope branch from e544ed1 to acded39 Compare October 14, 2023 11:21
@github-actions
Copy link

github-actions bot commented Oct 14, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@ITaluone ITaluone force-pushed the fix/respecting-formatting-options-in-inner-scope branch from acded39 to 1899a1b Compare October 14, 2023 11:33
@dennisdoomen dennisdoomen merged commit ed421ec into fluentassertions:develop Oct 14, 2023
@ITaluone ITaluone deleted the fix/respecting-formatting-options-in-inner-scope branch October 15, 2023 13:43
@jnyrup jnyrup mentioned this pull request Jul 2, 2024
Merged
7 tasks
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@ITaluone @jnyrup
Pass FormattingOptions to inner AssertionScope (fluentassertions#…
4e8923e 
…2329)

* Pass `FormattingOptions` to inner `AssertionScope`

* Add release notes

* Simplify the `AssertionOptions.Formatting` test
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@ITaluone @jnyrup
Pass FormattingOptions to inner AssertionScope (fluentassertions#…
77ad971 
…2329)

* Pass `FormattingOptions` to inner `AssertionScope`

* Add release notes

* Simplify the `AssertionOptions.Formatting` test
This was referenced Dec 8, 2025
Open
Merged
Open
Open
Closed
Closed
Open
Merged
Open
Closed
Closed
This was referenced Dec 21, 2025
Closed
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Open
Merged
Closed
Closed
Open
This was referenced Dec 29, 2025
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

+1 more reviewer

@IT-VBFK IT-VBFK IT-VBFK left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AssertionScope.FormattingOptions configured in surrounding AssertionScope do not seem to be respected by Should().BeEquivalentTo(collection)

5 participants

@ITaluone @coveralls @dennisdoomen @jnyrup @IT-VBFK