-
Notifications
You must be signed in to change notification settings - Fork 732
Ensure explicitly implemented members are discoverable in BeEquivalentTo #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dennisdoomen
merged 2 commits into
fluentassertions:develop
from
dennisdoomen:Fix/ExplicitInterfaceImpl
Sep 24, 2023
Merged
Ensure explicitly implemented members are discoverable in BeEquivalentTo #2152
dennisdoomen
merged 2 commits into
fluentassertions:develop
from
dennisdoomen:Fix/ExplicitInterfaceImpl
Sep 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bb8227 to
be218f7
Compare
7 tasks
be218f7 to
ed44bda
Compare
ed44bda to
d773221
Compare
jnyrup
reviewed
Jul 14, 2023
35fdb9b to
87cfed7
Compare
b391618 to
54d795c
Compare
Pull Request Test Coverage Report for Build 5847999939Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
13452cc to
31c4678
Compare
jnyrup
reviewed
Aug 13, 2023
20c998d to
279656a
Compare
This was referenced Dec 8, 2025
This was referenced Dec 21, 2025
This was referenced Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RespectingDeclaredTypesandRespectingRuntimeTypeswas used. But those options don't affect the subject.WithMappingconstruct also didn't support mapping to properties implemented through explicitly-implemented interfaces.Note I had to extend
MemberVisibilityto optionally include explicitly implemented members. This could be perceived as a breaking change. But it won't affect consumers, so for now, I treat it as non-breaking.Review
Review by commit and with whitespace changes hidden
Fixes #2146
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome