Get the System.Net.Http reference from the framework #2123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
force-pushed
the
Fix/NetHttpRef
branch
from
1a16d85 to
ffa085d
Compare
Pull Request Test Coverage Report for Build 4090839905
💛 - Coveralls |
7 tasks
AArnott
reviewed
Feb 4, 2023
| <ItemGroup> | ||
| <Reference Include="System.Data.DataSetExtensions" Condition="'$(TargetFramework)' == 'net472'" /> | ||
| <Reference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net472'"> | ||
| <HintPath>..\..\..\..\Program Files\dotnet\sdk\7.0.102\Microsoft\Microsoft.NET.Build.Extensions\net461\lib\System.Net.Http.dll</HintPath> |
Contributor
There was a problem hiding this comment.
This hintpath doesn't look ready for any machine where the repo was cloned at an arbitrary location.
AArnott
reviewed
Feb 4, 2023
| <Reference Include="System.Data" /> | ||
| <Reference Include="System.Xml" /> | ||
| <Reference Include="System.Xml.Linq" /> | ||
| <Reference Include="System.Net.Http" /> |
Contributor
There was a problem hiding this comment.
FWIW, I found in testing that this change wasn't enough for the nuspec to express this as a framework dependency in the nuspec. That's why in my PR I add an additional item.
Member
Author
There was a problem hiding this comment.
Let's continue with your PR
Pull Request Test Coverage Report for Build 4090839905Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2121 and #2120