Added NotCompleteWithinAsync for Task assertions
#1967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
requested changes
Aug 5, 2022
Member
dennisdoomen
left a comment
dennisdoomen
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Just some improvements.
Contributor
Author
|
I'm wondering why there is no "comment" from coveralls with the coverage report!? |
Member
It sometimes doesn't update the PR, but the analysis did run. |
jnyrup
reviewed
Aug 7, 2022
Tests/FluentAssertions.Specs/Specialized/TaskOfTAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
dennisdoomen
approved these changes
Aug 9, 2022
lg2de
force-pushed
the
not-complete-within
branch
from
9762bf1 to
7a2803f
Compare
Pull Request Test Coverage Report for Build 2827500804Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
jnyrup
reviewed
Aug 9, 2022
lg2de
force-pushed
the
not-complete-within
branch
from
48ab0e9 to
6d4019b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Would be great to merge this PR without squashing because of the refactorings. |
lg2de
changed the title
Member
If you would squash some of the commits that belong together and keep the refactoring and renames separate, we can. |
…it_time_it_should_fail
lg2de
force-pushed
the
not-complete-within
branch
from
b22f20f to
59398c8
Compare
Contributor
Author
Hope, this is sufficient. |
jnyrup
approved these changes
Aug 13, 2022
jnyrup
changed the title
NotCompleteWithinAsync for Task assertions
This was referenced Aug 14, 2022
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
Oct 25, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [FluentAssertions](https://www.fluentassertions.com/) ([source](https://togithub.com/fluentassertions/fluentassertions)) | nuget | minor | `6.7.0` -> `6.8.0` | --- ### Release Notes <details> <summary>fluentassertions/fluentassertions</summary> ### [`v6.8.0`](https://togithub.com/fluentassertions/fluentassertions/releases/tag/6.8.0) [Compare Source](https://togithub.com/fluentassertions/fluentassertions/compare/6.7.0...6.8.0) <!-- Release notes generated using configuration in .github/release.yml at develop --> ##### What's Changed ##### New features - Extend collection assertions with `ContainInConsecutiveOrder` and `NotContainInConsecutiveOrder` by [@​StacyCash](https://togithub.com/StacyCash) in [https://github.com/fluentassertions/fluentassertions/pull/1963](https://togithub.com/fluentassertions/fluentassertions/pull/1963) - Added `NotCompleteWithinAsync` for Task assertions by [@​lg2de](https://togithub.com/lg2de) in [https://github.com/fluentassertions/fluentassertions/pull/1967](https://togithub.com/fluentassertions/fluentassertions/pull/1967) - Added assertions for non-generic `TaskCompletionSource` by [@​lg2de](https://togithub.com/lg2de) in [https://github.com/fluentassertions/fluentassertions/pull/1961](https://togithub.com/fluentassertions/fluentassertions/pull/1961) - Exposes the `IMonitor` object to extensions methods. by [@​A-Kjeldgaard](https://togithub.com/A-Kjeldgaard) in [https://github.com/fluentassertions/fluentassertions/pull/2010](https://togithub.com/fluentassertions/fluentassertions/pull/2010) ##### Improvements - Optimize `BeEquivalentTo` by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1939](https://togithub.com/fluentassertions/fluentassertions/pull/1939) - Print commas at the end of the line by [@​ronaldkroon](https://togithub.com/ronaldkroon) in [https://github.com/fluentassertions/fluentassertions/pull/1945](https://togithub.com/fluentassertions/fluentassertions/pull/1945) - Avoid allocating sub-arrays in `ContainInOrder` by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1960](https://togithub.com/fluentassertions/fluentassertions/pull/1960) - Extend `IObjectInfo` with info about `DeclaringType` by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [https://github.com/fluentassertions/fluentassertions/pull/1950](https://togithub.com/fluentassertions/fluentassertions/pull/1950) - Prepare constructors of `AsyncFunctionAssertions` to make them protected in V7 by [@​lg2de](https://togithub.com/lg2de) in [https://github.com/fluentassertions/fluentassertions/pull/1972](https://togithub.com/fluentassertions/fluentassertions/pull/1972) - Calculate the difference between the subject and the expected nearby time by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [https://github.com/fluentassertions/fluentassertions/pull/2013](https://togithub.com/fluentassertions/fluentassertions/pull/2013) ##### Fixes - Filter dynamic methods from stack trace by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1943](https://togithub.com/fluentassertions/fluentassertions/pull/1943) - Make For/Excluding work with nested paths by [@​whymatter](https://togithub.com/whymatter) in [https://github.com/fluentassertions/fluentassertions/pull/1953](https://togithub.com/fluentassertions/fluentassertions/pull/1953) - Use InvariantCulture when doing case-insensitive matches by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1985](https://togithub.com/fluentassertions/fluentassertions/pull/1985) - Global record equivalency settings were not taken into account by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [https://github.com/fluentassertions/fluentassertions/pull/1984](https://togithub.com/fluentassertions/fluentassertions/pull/1984) - Escape brackets in execution time failures by [@​Briaoeuidhtns](https://togithub.com/Briaoeuidhtns) in [https://github.com/fluentassertions/fluentassertions/pull/1994](https://togithub.com/fluentassertions/fluentassertions/pull/1994) ##### Documentation - More specifically clarify the intentions of `WithArgs` by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1929](https://togithub.com/fluentassertions/fluentassertions/pull/1929) - Remove building link from the website by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [https://github.com/fluentassertions/fluentassertions/pull/1934](https://togithub.com/fluentassertions/fluentassertions/pull/1934) - Add `Enum.BeOneOf` to the docs by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1958](https://togithub.com/fluentassertions/fluentassertions/pull/1958) - Document how to use `ModuleInitializer` by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1966](https://togithub.com/fluentassertions/fluentassertions/pull/1966) - Fix a typo on the Assembly References documentation page by [@​asydikov](https://togithub.com/asydikov) in [https://github.com/fluentassertions/fluentassertions/pull/1970](https://togithub.com/fluentassertions/fluentassertions/pull/1970) - Update summary of `EquivalencyValidator` by [@​Wolgo](https://togithub.com/Wolgo) in [https://github.com/fluentassertions/fluentassertions/pull/1991](https://togithub.com/fluentassertions/fluentassertions/pull/1991) - Improve error messages for accidental `Equals` usage by [@​nycdotnet](https://togithub.com/nycdotnet) in [https://github.com/fluentassertions/fluentassertions/pull/2006](https://togithub.com/fluentassertions/fluentassertions/pull/2006) ##### Others - Upgrade to C# 10 by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1935](https://togithub.com/fluentassertions/fluentassertions/pull/1935) - Use file scoped namespaces by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1936](https://togithub.com/fluentassertions/fluentassertions/pull/1936) - More use of pattern matching and lifted operators by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1937](https://togithub.com/fluentassertions/fluentassertions/pull/1937) - Update nuget packages by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1962](https://togithub.com/fluentassertions/fluentassertions/pull/1962) - Make it possible for third-party libraries to access the underlying collection of instances of `ReadOnlyNonGenericCollectionWrapper` by [@​logiclrd](https://togithub.com/logiclrd) in [https://github.com/fluentassertions/fluentassertions/pull/1968](https://togithub.com/fluentassertions/fluentassertions/pull/1968) - Code cleanups by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1973](https://togithub.com/fluentassertions/fluentassertions/pull/1973) - Improve coverage for `CollectionMemberObjectInfo` by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [https://github.com/fluentassertions/fluentassertions/pull/1983](https://togithub.com/fluentassertions/fluentassertions/pull/1983) - Deduplicate target frameworks by [@​0xced](https://togithub.com/0xced) in [https://github.com/fluentassertions/fluentassertions/pull/1980](https://togithub.com/fluentassertions/fluentassertions/pull/1980) - Removed netcoreapp2.0 framework check in formatting precision tests by [@​iliashkolyar](https://togithub.com/iliashkolyar) in [https://github.com/fluentassertions/fluentassertions/pull/1976](https://togithub.com/fluentassertions/fluentassertions/pull/1976) - Rename `ShouldCompareMembersThisDeep` to `ShouldCompareNodesThisDeep` by [@​Wolgo](https://togithub.com/Wolgo) in [https://github.com/fluentassertions/fluentassertions/pull/1992](https://togithub.com/fluentassertions/fluentassertions/pull/1992) - Update nuget packages by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1996](https://togithub.com/fluentassertions/fluentassertions/pull/1996) - Cleanups by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/1998](https://togithub.com/fluentassertions/fluentassertions/pull/1998) - Update GitHub actions by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/2007](https://togithub.com/fluentassertions/fluentassertions/pull/2007) - Fix the PR link in releases.md by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [https://github.com/fluentassertions/fluentassertions/pull/2014](https://togithub.com/fluentassertions/fluentassertions/pull/2014) - Prepare 6.8.0 by [@​jnyrup](https://togithub.com/jnyrup) in [https://github.com/fluentassertions/fluentassertions/pull/2020](https://togithub.com/fluentassertions/fluentassertions/pull/2020) ##### New Contributors - [@​StacyCash](https://togithub.com/StacyCash) made their first contribution in [https://github.com/fluentassertions/fluentassertions/pull/1963](https://togithub.com/fluentassertions/fluentassertions/pull/1963) - [@​asydikov](https://togithub.com/asydikov) made their first contribution in [https://github.com/fluentassertions/fluentassertions/pull/1970](https://togithub.com/fluentassertions/fluentassertions/pull/1970) - [@​0xced](https://togithub.com/0xced) made their first contribution in [https://github.com/fluentassertions/fluentassertions/pull/1980](https://togithub.com/fluentassertions/fluentassertions/pull/1980) - [@​Wolgo](https://togithub.com/Wolgo) made their first contribution in [https://github.com/fluentassertions/fluentassertions/pull/1991](https://togithub.com/fluentassertions/fluentassertions/pull/1991) - [@​Briaoeuidhtns](https://togithub.com/Briaoeuidhtns) made their first contribution in [https://github.com/fluentassertions/fluentassertions/pull/1994](https://togithub.com/fluentassertions/fluentassertions/pull/1994) - [@​nycdotnet](https://togithub.com/nycdotnet) made their first contribution in [https://github.com/fluentassertions/fluentassertions/pull/2006](https://togithub.com/fluentassertions/fluentassertions/pull/2006) - [@​A-Kjeldgaard](https://togithub.com/A-Kjeldgaard) made their first contribution in [https://github.com/fluentassertions/fluentassertions/pull/2010](https://togithub.com/fluentassertions/fluentassertions/pull/2010) **Full Changelog**: fluentassertions/fluentassertions@6.7.0...6.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuOSIsInVwZGF0ZWRJblZlciI6IjMyLjI0MS45In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 1, 2025
Closed
This was referenced Sep 22, 2025
Closed
This was referenced Sep 29, 2025
Closed
This was referenced Oct 20, 2025
Closed
Closed
This was referenced Nov 24, 2025
Closed
This was referenced Dec 1, 2025
Closed
This was referenced Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to
CompleteWithAsyncin assertions forTaskandTask<T>, and similar to assertions forTaskCompletionSource, I addedNotCompleteWithinAsync.Checking the existing tests I found some inconsistency which I've fixed (hopefully) in several separate commits. Maybe you want to review these commits one by one for better overview.