Using BeEquivalentTo on a collection with nested collections would throw on missing members
#1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
force-pushed
the
Fix/1710
branch
from
db0c747 to
e7359ff
Compare
…complain about missing members If a collection contains another collection referring to objects without visible properties, BeEquivalentTo will throw and complain about missing members. This was caused by the IsRoot property on INode that misinterpreted the path string [0].MyProperty[0] as if we were processing the objects in the root collection.
dennisdoomen
force-pushed
the
Fix/1710
branch
from
e7359ff to
88bc3b5
Compare
jnyrup
approved these changes
Oct 20, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a collection contains another collection referring to objects without visible properties,
BeEquivalentTowill throw and complain about missing members. This was caused by theIsRootproperty onINodethat misinterpreted the path string[0].MyProperty[0]as if we were processing the objects in the root collection.Fixed #1710