Skip to content

Robust methodinfo assertions #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 2 commits into from
May 14, 2021
Merged

Robust methodinfo assertions #1559

dennisdoomen merged 2 commits into from
May 14, 2021

Conversation

@eNeRGy164
Copy link
Contributor

@eNeRGy164 eNeRGy164 commented May 14, 2021

More coverage of #1039

  • Added failure message when Subject is null
  • Added Guards against null parameters

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution adds a feature or fixes a bug, please update the release notes, which are published on the website.
  • If the contribution changes the public API the changes needs to be included by running AcceptApiChanges.ps1/AcceptApiChanges.sh.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

dennisdoomen
dennisdoomen approved these changes May 14, 2021
View reviewed changes
Tests/FluentAssertions.Specs/Types/MethodBaseAssertionSpecs.cs
}

[Fact]
public void When_subject_is_null_return_should_fail()
Copy link
Member

@dennisdoomen dennisdoomen May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to improve this naming convention or the grouping of tests, because using the literal name in the test name is what I want to avoid.

It would be fine if it said: When subject is null, return should fail. But without the markup, it's difficult to read as a sentence.

@dennisdoomen dennisdoomen merged commit 148b27b into fluentassertions:develop May 14, 2021
@eNeRGy164 eNeRGy164 deleted the robust-methodinfo-assertions branch May 19, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eNeRGy164 @dennisdoomen @jnyrup