Skip to content

Add overloads of MatchRegex and NotMatchRegex that take System.Text.RegularExpressions.Regex #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 4 commits into from
Nov 24, 2020
Merged

Add overloads of MatchRegex and NotMatchRegex that take System.Text.RegularExpressions.Regex #1436

dennisdoomen merged 4 commits into from
Nov 24, 2020

Conversation

@kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Nov 23, 2020 •
edited
Loading

Visual Studio 2019 supports regex syntax highlighting of System.Text.RegularExpressions.Regex.

https://devblogs.microsoft.com/dotnet/visual-studio-2019-net-productivity/#regex-language-support

image

I want overloads of StringAssertions.MatchRegex and StringAssertions.NotMatchRegex that take System.Text.RegularExpressions.Regex.

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution adds a feature or fixes a bug, please update the release notes, which are published on the website.
  • If the contribution changes the public API the changes needs to be included by running AcceptApiChanges.ps1/AcceptApiChanges.sh.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@kzrnm
Copy link
Contributor Author

kzrnm commented Nov 23, 2020

  • When_a_string_is_matched_against_an_invalid_regex_it_should_throw_with_a_clear_explanation
  • When_a_string_is_matched_against_an_invalid_regex_it_should_only_have_one_failure_message
  • When_a_string_is_negatively_matched_against_an_invalid_regex_it_should_throw_with_a_clear_explanation
  • When_a_string_is_negatively_matched_against_an_invalid_regex_it_only_contain_one_failure_message

I didn't write these test bacause new System.Text.RegularExpressions.Regex(".**") throws ArgumentException.

@kzrnm kzrnm marked this pull request as ready for review November 23, 2020 10:12
@dennisdoomen dennisdoomen changed the title add overloads of MatchRegex and NotMatchRegex that take System.Text.RegularExpressions.Regex Add overloads of MatchRegex and NotMatchRegex that take System.Text.RegularExpressions.Regex Nov 23, 2020
dennisdoomen
dennisdoomen reviewed Nov 23, 2020
View reviewed changes
@dennisdoomen
Copy link
Member

dennisdoomen commented Nov 23, 2020

Visual Studio 2019 supports regex syntax highlighting of System.Text.RegularExpressions.Regex.

FYI, Jetbrains Rider also allows you to do that with string literals.

@kzrnm
Copy link
Contributor Author

kzrnm commented Nov 23, 2020 •
edited
Loading

@dennisdoomen Thank you for your review. I have updated string regularExpression overloads and releases.md.

@dennisdoomen dennisdoomen requested a review from jnyrup November 23, 2020 15:51
@dennisdoomen dennisdoomen merged commit cfe930f into fluentassertions:develop Nov 24, 2020
@kzrnm kzrnm deleted the feature/regex_overloads branch November 24, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kzrnm @dennisdoomen @jnyrup