Skip to content

Renamed [Start|End]WithEquivalent to [Start|End]WithEquivalentOf #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Mar 31, 2020
Merged

Renamed [Start|End]WithEquivalent to [Start|End]WithEquivalentOf #1292

dennisdoomen merged 1 commit into from
Mar 31, 2020

Conversation

@eNeRGy164
Copy link
Contributor

@eNeRGy164 eNeRGy164 commented Mar 29, 2020 •
edited
Loading

Renamed StartWithEquivalent and EndWithEquivalent to StartWithEquivalentOf and EndWithEquivalentOf to make the API for Equivalent methods consistent

Closes #1286

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

jnyrup
jnyrup reviewed Mar 29, 2020
View reviewed changes
@jnyrup
Copy link
Member

jnyrup commented Mar 30, 2020

@eNeRGy164 If you just rebase on develop to clean out the paramref changes, I believe it's ready to be merged.

@eNeRGy164
Copy link
Contributor Author

eNeRGy164 commented Mar 30, 2020

That should be it

@jnyrup jnyrup requested a review from dennisdoomen March 31, 2020 05:30
@dennisdoomen dennisdoomen merged commit 93cf4c6 into fluentassertions:develop Mar 31, 2020
@eNeRGy164 eNeRGy164 deleted the start-end-withequivalent branch March 31, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent naming for StartWithEquivalent and EndWithEquivalent

3 participants

@eNeRGy164 @jnyrup @dennisdoomen