Skip to content

Add BooleanAssertions.NotBe #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 1 commit into from
Mar 31, 2020
Merged

Add BooleanAssertions.NotBe #1290

jnyrup merged 1 commit into from
Mar 31, 2020

Conversation

@eNeRGy164
Copy link
Contributor

@eNeRGy164 eNeRGy164 commented Mar 29, 2020

Add assertion method NotBe to BooleanAssertions.

Closes #1285

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

jnyrup
jnyrup requested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line to releases.md as well.

@eNeRGy164 eNeRGy164 requested a review from jnyrup March 29, 2020 21:03
@jnyrup
Copy link
Member

jnyrup commented Mar 30, 2020

@eNeRGy164 If you just rebase on develop to clean out the paramref changes, I believe it's ready to be merged.

@eNeRGy164
Copy link
Contributor Author

eNeRGy164 commented Mar 30, 2020

That should be it

dennisdoomen
dennisdoomen approved these changes Mar 31, 2020
View reviewed changes
Tests/FluentAssertions.Specs/Primitives/BooleanAssertionSpecs.cs
}

[Fact]
public void Should_fail_when_asserting_boolean_value_not_to_be_equal_to_a_different_value()
Copy link
Member

@dennisdoomen dennisdoomen Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this one since you already have a test with because and one without.

Copy link
Contributor Author

@eNeRGy164 eNeRGy164 Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same could be said for the existing Should_fail_when_asserting_boolean_value_to_be_equal_to_a_different_value of which this is a copy?

Copy link
Member

@dennisdoomen dennisdoomen Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point.

@jnyrup jnyrup merged commit d845ab9 into fluentassertions:develop Mar 31, 2020
@eNeRGy164 eNeRGy164 deleted the boolean.notbe branch March 31, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BooleanAssertions.NotBe

3 participants

@eNeRGy164 @jnyrup @dennisdoomen