Use Ordinal[IgnoreCase] string comparison #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests should behave the same no matter the culture of the machine being run on.
dennisdoomen
approved these changes
Mar 29, 2020
Member
dennisdoomen
left a comment
dennisdoomen
left a comment
There was a problem hiding this comment.
So using ordinal case-insensitive for string comparisons should be another design guideline. Maybe we should add them to the PR template?
Member
Author
Would fine be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests should behave the same no matter the culture of the machine being run on.
StringComparisonis not specified.BannedSymbols.txtto prohibit usage of culture awareStringComparisonandCultureInfo.As netcoreapp2.1/netcoreapp3.0/netstandard2.1 has more string overloads than net47/netstandard2.0 I added some dummy overloads in
SystemExtensionsto satisfy the analyzers.One large difference in behavior is that
TryConversionStepnow usesCultureInfo.Invariantinstead ofCultureInfo.CurrentCulture.This fixes #1096
This closes #1184 (Thanks @kimsey0 for pushing this change forward)