Constrain generic type on NumericAssertions #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
Mar 8, 2020
Member
dennisdoomen
left a comment
dennisdoomen
left a comment
There was a problem hiding this comment.
I'm trying to remember why I didn't do this in the first place, but the only thing I can recall that I struggled a lot with compilation errors and the compiler selecting the wrong overload.
lg2de
reviewed
Mar 8, 2020
Further constraining of `T` to `IComparable` gets us: * Catching misuses of constructor on compile time instead of runtime * Avoid (un)boxing of primitives * Type preserving `Subject`
Member
Author
|
Glad to hear there was a reason back then. Tried to dig in history to see if I could find a cause:
But I didn't find any compilation issues... |
jnyrup
added a commit
to jnyrup/fluentassertions
that referenced
this pull request
Mar 13, 2020
jnyrup
added a commit
to jnyrup/fluentassertions
that referenced
this pull request
Mar 21, 2020
This was referenced May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further constraining of
TtoIComparable<T>gets us:Subject, i.e.T/T?instead ofIComparable<T>