Skip to content

Add Match method to Numeric and NullableNumeric assertions #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 3 commits into from
Aug 13, 2019
Merged

Add Match method to Numeric and NullableNumeric assertions #1112

jnyrup merged 3 commits into from
Aug 13, 2019

Conversation

@Liklainy
Copy link
Contributor

@Liklainy Liklainy commented Aug 9, 2019

Fix #372

  • Added Match for NumericAssertions and NullableNumericAssertions
  • Added simple tests

@dennisdoomen
Copy link
Member

dennisdoomen commented Aug 9, 2019

You may want to update the docs in the same PR.

jnyrup
jnyrup requested changes Aug 10, 2019
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this feature @Liklainy!
It blends perfectly into the API.
I've only got a few minor comments to that I hope you will address before merging this.

@jnyrup jnyrup merged commit 9dcc715 into fluentassertions:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Match() for non-reference types?

3 participants

@Liklainy @dennisdoomen @jnyrup