Remove unnecessary GEM_HOME/GEM_PATH settings#752
Merged
Conversation
Remove environment variables that prevent zero-downtime-restart feature of Fluentd v1.18.0. This is because an upgrade with a Ruby version update will not work correctly due to environment variables for the old Ruby. Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]>
22b20d8 to
251bd3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove environment variables that prevent zero-downtime-restart feature of Fluentd v1.18.0. This is because an upgrade with a Ruby version update will not work correctly due to environment variables for the old Ruby.
Note: Cherry-picked 9762e1f on
feature-nodowntimebranch.