Skip to content

Fix deprecated usage of ERB.new#685

Merged
kenhys merged 1 commit intofluent:masterfrom
kenhys:fix-deprecated
Oct 7, 2024
Merged

Fix deprecated usage of ERB.new#685
kenhys merged 1 commit intofluent:masterfrom
kenhys:fix-deprecated

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented Oct 4, 2024

It fixes the following warning (Since Ruby 3.1):

Rakefile:168: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
Rakefile:168: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

This does not change the content of fluent-package.

It fixes the following warning (Since Ruby 3.1):

  Rakefile:168: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
  Rakefile:168: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

This does not change the content of fluent-package.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys requested a review from daipom October 4, 2024 09:22
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kenhys kenhys merged commit b0dde24 into fluent:master Oct 7, 2024
@kenhys kenhys deleted the fix-deprecated branch October 7, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants