Add HTMLQuerySelectorAll & HTMLQuerySelector scalar functions#1960
Merged
norberttech merged 4 commits intoflow-php:1.xfrom Nov 9, 2025
Merged
Add HTMLQuerySelectorAll & HTMLQuerySelector scalar functions#1960norberttech merged 4 commits intoflow-php:1.xfrom
HTMLQuerySelectorAll & HTMLQuerySelector scalar functions#1960norberttech merged 4 commits intoflow-php:1.xfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #1960 +/- ##
==========================================
- Coverage 79.37% 79.09% -0.29%
==========================================
Files 837 839 +2
Lines 24959 24952 -7
==========================================
- Hits 19812 19735 -77
- Misses 5147 5217 +70
🚀 New features to boost your workflow:
|
Member
Author
|
Coverage is a lie, as it runs on 8.2, but only part of the test is run on 8.4. |
norberttech
reviewed
Nov 6, 2025
Member
|
Both scalar functions must come with integration tests (like all other scalar functions) that shows how this works with a full pipeline |
norberttech
reviewed
Nov 6, 2025
src/core/etl/tests/Flow/ETL/Tests/Integration/Function/HTMLQuerySelectorAllTest.php
Show resolved
Hide resolved
norberttech
reviewed
Nov 6, 2025
stloyd
force-pushed
the
task/1915-html-fn
branch
from
6de9723 to
92e7c14
Compare
stloyd
force-pushed
the
task/1915-html-fn
branch
from
d5b2eb9 to
9b89271
Compare
norberttech
reviewed
Nov 8, 2025
norberttech
reviewed
Nov 8, 2025
norberttech
reviewed
Nov 8, 2025
norberttech
reviewed
Nov 8, 2025
stloyd
force-pushed
the
task/1915-html-fn
branch
from
f9bf415 to
0156e72
Compare
norberttech
reviewed
Nov 8, 2025
stloyd
force-pushed
the
task/1915-html-fn
branch
2 times, most recently
from
192ba6d to
709d414
Compare
norberttech
reviewed
Nov 8, 2025
stloyd
force-pushed
the
task/1915-html-fn
branch
from
e985ea8 to
5f3407e
Compare
norberttech
reviewed
Nov 9, 2025
stloyd
force-pushed
the
task/1915-html-fn
branch
from
5f3407e to
54625ff
Compare
norberttech
reviewed
Nov 9, 2025
norberttech
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1915
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security