Skip to content

Fix month select issue when Enter key is pressed #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joselrio wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix month select issue when Enter key is pressed #3045

joselrio wants to merge 3 commits into from

Conversation

@joselrio
Copy link

@joselrio joselrio commented Aug 30, 2024

This PR will fix the following issues:

  • Fixed the issue that was causing year to be update when Enter key was pressed at the month select only if month didn't change;
  • Improve the month selector in order to give the ability to open it also by using arrows up and down keys;

Preview:

With Issue:
dp-issue

Fixed:
dp-fixed

Zierk59 pushed a commit to Zierk59/flatpickr that referenced this pull request May 12, 2025
@Kreiz69
Merge upstream PR flatpickr#3045
8c08a9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@OS-giulianasilva OS-giulianasilva OS-giulianasilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joselrio @BenOsodrac @OS-giulianasilva