No WRONG_DATA for function pointer with unknown return type (cppcheck-opensource#4893)

chrchr-github · web-flow · commit 319baf8d0f97 · 2023-03-18T14:52:29.000+01:00
diff --git a/lib/checkfunctions.cpp b/lib/checkfunctions.cpp
@@ -268,7 +268,7 @@ void CheckFunctions::checkIgnoredReturnValue()
             }
 
             if ((!tok->function() || !Token::Match(tok->function()->retDef, "void %name%")) &&
-                !WRONG_DATA(!tok->next()->astOperand1(), tok)) {
+                tok->next()->astOperand1()) {
                 const Library::UseRetValType retvalTy = mSettings->library.getUseRetValType(tok);
                 const bool warn = (tok->function() && tok->function()->isAttributeNodiscard()) || // avoid duplicate warnings for resource-allocating functions
                                   (retvalTy == Library::UseRetValType::DEFAULT && mSettings->library.getAllocFuncInfo(tok) == nullptr);
diff --git a/test/testfunctions.cpp b/test/testfunctions.cpp
@@ -1998,6 +1998,11 @@ class TestFunctions : public TestFixture {
               "}\n");
         ASSERT_EQUALS("", errout.str());
 
+        check("void f() {\n"
+              "    INT (*g)() = nullptr;\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
+
         settings = settings_old;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ void CheckFunctions::checkIgnoredReturnValue()`
`268`	`268`	`}`
`269`	`269`
`270`	`270`	`if ((!tok->function() \|\| !Token::Match(tok->function()->retDef, "void %name%")) &&`
`271`		`- !WRONG_DATA(!tok->next()->astOperand1(), tok)) {`
	`271`	`+ tok->next()->astOperand1()) {`
`272`	`272`	`const Library::UseRetValType retvalTy = mSettings->library.getUseRetValType(tok);`
`273`	`273`	`const bool warn = (tok->function() && tok->function()->isAttributeNodiscard()) \|\| // avoid duplicate warnings for resource-allocating functions`
`274`	`274`	`(retvalTy == Library::UseRetValType::DEFAULT && mSettings->library.getAllocFuncInfo(tok) == nullptr);`