GUI: Suppressing addon warnings

danmar · danmar · commit 16dc8a054064 · 2019-08-09T19:00:09.000+02:00
diff --git a/gui/checkthread.cpp b/gui/checkthread.cpp
@@ -360,12 +360,16 @@ void CheckThread::parseAddonErrors(QString err, const QString &tool)
         const int column = obj["col"].toInt();
         const std::string severity = obj["severity"].toString().toStdString();
         const std::string message = obj["message"].toString().toStdString();
-        const std::string id = obj["errorId"].toString().toStdString();
+        const std::string id = (obj["addon"].toString() + "-" + obj["errorId"].toString()).toStdString();
 
         std::list<ErrorLogger::ErrorMessage::FileLocation> callstack;
         callstack.push_back(ErrorLogger::ErrorMessage::FileLocation(filename, lineNumber));
         callstack.back().col = column;
         ErrorLogger::ErrorMessage errmsg(callstack, filename, Severity::fromString(severity), message, id, false);
+
+        if (isSuppressed(errmsg.toSuppressionsErrorMessage()))
+            continue;
+
         mResult.reportErr(errmsg);
     }
 }
@@ -452,15 +456,9 @@ void CheckThread::parseClangErrors(const QString &tool, const QString &file0, QS
         errorMessage.errorId = e.errorId.toStdString();
         errorMessage.symbolNames = e.symbolNames.toStdString();
 
-        bool isSuppressed = false;
-        foreach (const Suppressions::Suppression &suppression, mSuppressions) {
-            if (suppression.isSuppressed(errorMessage)) {
-                isSuppressed = true;
-                break;
-            }
-        }
-        if (isSuppressed)
+        if (isSuppressed(errorMessage))
             continue;
+
         std::list<ErrorLogger::ErrorMessage::FileLocation> callstack;
         foreach (const QErrorPathItem &path, e.errorPath) {
             callstack.push_back(ErrorLogger::ErrorMessage::FileLocation(path.file.toStdString(), path.info.toStdString(), path.line));
@@ -473,6 +471,15 @@ void CheckThread::parseClangErrors(const QString &tool, const QString &file0, QS
     }
 }
 
+bool CheckThread::isSuppressed(const Suppressions::ErrorMessage &errorMessage) const
+{
+    foreach (const Suppressions::Suppression &suppression, mSuppressions) {
+        if (suppression.isSuppressed(errorMessage))
+            return true;
+    }
+    return false;
+}
+
 QString CheckThread::clangCmd()
 {
     QString path = QSettings().value(SETTINGS_CLANG_PATH,QString()).toString();
diff --git a/gui/checkthread.h b/gui/checkthread.h
@@ -147,6 +147,8 @@ class CheckThread : public QThread {
     void parseAddonErrors(QString err, const QString &tool);
     void parseClangErrors(const QString &tool, const QString &file0, QString err);
 
+    bool isSuppressed(const Suppressions::ErrorMessage &errorMessage) const;
+
     QStringList mFiles;
     bool mAnalyseWholeProgram;
     QStringList mAddonsAndTools;
