This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Additional source-map util refactors#363
Merged
Merged
Conversation
jasonLaster
commented
Jul 19, 2016
jasonLaster
commented
Contributor
- underscore private methods
- rename setSourceMap to setConsumer and make it private
- move some methods around
+ underscore private methods + rename setSourceMap to setConsumer and make it private
Contributor
|
Looks good r+ (as mentioned on IRC you could convince me that we don't need the private underscore, I'm on the fence...) |
Contributor
Author
|
ha - yeah. this is more a symptom of not having a clear idea for the util yet. it's a bag of functions that keeps changing based on my goals... when it settles down i'll see what we have :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.