Update the Firestore init() flow to handle non-default databases#7655
Merged
joehan merged 3 commits intofirebase:masterfrom Sep 16, 2024
Merged
Update the Firestore init() flow to handle non-default databases#7655joehan merged 3 commits intofirebase:masterfrom
joehan merged 3 commits intofirebase:masterfrom
Conversation
…allowing the user to input the name of the database they want to initialize. This is a catch for older projects created in Cloud, which have a (default) non-Firestore Native database in their projects before they add Firebase.
…allowing the user to input the name of the database they want to initialize. This is a catch for older projects created in Cloud, which have a (default) non-Firestore Native database in their projects before they add Firebase.
joehan
approved these changes
Sep 13, 2024
Member
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
Thanks a ton for implementing this!
pr-Mais
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Update the Firestore init() flow to handle non-default databases, by allowing the user to input the name of the database they want to initialize. This is a catch for older projects created in Cloud, which have a (default) non-Firestore Native database in their projects before they add Firebase. * Update the Firestore init() flow to handle non-default databases, by allowing the user to input the name of the database they want to initialize. This is a catch for older projects created in Cloud, which have a (default) non-Firestore Native database in their projects before they add Firebase. * Changelog --------- Co-authored-by: joehan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the Firestore init() flow to handle non-default databases, by allowing the user to input the name of the database they want to initialize.
This is a catch for older projects created in Cloud, which have a (default) non-Firestore Native database in their projects before they add Firebase. New projects shouldn't be affected by this change.
The only other thought I had was maybe it would be better to have input of database name during init by default but defaulting to (default) with option to enter your own without first hitting a 404.
Scenarios Tested
Projects created with older (default) database, deleting that and creating a new Firestore database with a different name.
Sample Commands
Nothing new, just additional ask for database name if (default) doesnt exist, which would fail out without reason previously.