App Hosting: GitHub integration improvements#7405
Conversation
mathu97
changed the title
mathu97
force-pushed
the
refactor/github-connections-poc
branch
from
941230a to
d7f2de2
Compare
| await createFullyInstalledConnection(projectId, location, generateConnectionId(), oauthConn), | ||
| while (installationId === ADD_ACCOUNT_CHOICE) { | ||
| utils.logBullet( | ||
| "Install the Firebase App Hosting GitHub app on a new account to enable access to those repositories", |
There was a problem hiding this comment.
nit* not blocking
I wonder how surprising it is for users to ultimately be redirected to DevConnect. It looks friendly enough, and even says you should close the page, but I wonder if we should give a hint here about what to expect when a popup is open.
There was a problem hiding this comment.
hmm we could add some messaging here but I feel that this would make it too verbose. Ideally we redirect to a firebase branded success page which we can look into separately.
| return conn; | ||
| } | ||
|
|
||
| async function manageInstallation(connection: devConnect.Connection): Promise<void> { |
There was a problem hiding this comment.
nit* it looks like "manage" is an intentional choice of word here but I was confused because I expected it to be "update" or "configure". Curious why you ended up deciding on "manage".
There was a problem hiding this comment.
I thought "manage" makes sense because it takes them to the installation page from which users can either, update the installation's repository access, suspend the installation, or uninstall the GitHub app. I think "configure" could work here as well.
taeold
left a comment
taeold
left a comment
There was a problem hiding this comment.
Can you add a changelog entry?
3 participants
Uh oh!
There was an error while loading. Please reload this page.