Markduckworth/or queries 4274 by MarkDuckworth · Pull Request #6896 · firebase/firebase-js-sdk

MarkDuckworth · 2022-12-16T18:27:12Z

Port of markduckworth/or-queries-4274

Update documentation for or() and and()
Update the canonical ID computation for flat conjunctions.

…ID of old style implicit flat conjunctions.

…in the Android implementation.

changeset-bot · 2022-12-16T18:27:15Z

🦋 Changeset detected

Latest commit: 76de87e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-12-16T19:01:14Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (d8af08f) Merge (ea9efff) Diff
browser 272 kB 273 kB +52 B (+0.0%)
esm5 339 kB 339 kB +69 B (+0.0%)
main 545 kB 545 kB +120 B (+0.0%)
module 272 kB 273 kB +52 B (+0.0%)
react-native 273 kB 273 kB +52 B (+0.0%)

`bundle`

Type	Base (`d8af08f`)	Merge (ea9efff)	Diff
firestore (Persistence)	281 kB	281 kB	+52 B (+0.0%)
firestore (Query Cursors)	220 kB	220 kB	+52 B (+0.0%)
firestore (Query)	217 kB	217 kB	+52 B (+0.0%)
firestore (Read data once)	205 kB	205 kB	+52 B (+0.0%)
firestore (Realtime updates)	207 kB	207 kB	+52 B (+0.0%)
firestore (Transaction)	188 kB	188 kB	+52 B (+0.0%)
firestore (Write data)	188 kB	188 kB	+52 B (+0.0%)

firebase
Type Base (d8af08f) Merge (ea9efff) Diff
firebase-compat.js 745 kB 746 kB +49 B (+0.0%)
firebase-firestore-compat.js 320 kB 320 kB +49 B (+0.0%)
firebase-firestore.js 321 kB 321 kB +52 B (+0.0%)

Test Logs

Base (d8af08f): https://github.com/firebase/firebase-js-sdk/actions/runs/3689697834
Merge (ea9efff): https://github.com/firebase/firebase-js-sdk/actions/runs/3732931091

https://storage.googleapis.com/firebase-sdk-metric-reports/SZV2w0qqeU.html

google-oss-bot · 2022-12-16T19:29:53Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- addDoc
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 118 kB 118 kB +52 B (+0.0%)
  size-with-ext-deps 178 kB 178 kB +52 B (+0.0%)
- deleteDoc
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 109 kB 109 kB +52 B (+0.0%)
  size-with-ext-deps 169 kB 169 kB +52 B (+0.0%)
- disableNetwork
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 97.5 kB 97.6 kB +52 B (+0.1%)
  size-with-ext-deps 157 kB 157 kB +52 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 179 kB 179 kB +52 B (+0.0%)
  size-with-ext-deps 239 kB 239 kB +52 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 211 kB 211 kB +52 B (+0.0%)
  size-with-ext-deps 271 kB 271 kB +52 B (+0.0%)
- enableNetwork
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 97.5 kB 97.6 kB +52 B (+0.1%)
  size-with-ext-deps 157 kB 157 kB +52 B (+0.0%)
- executeWrite
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 108 kB 108 kB +52 B (+0.0%)
  size-with-ext-deps 168 kB 168 kB +52 B (+0.0%)
- getCountFromServer
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 104 kB 104 kB +52 B (+0.0%)
  size-with-ext-deps 164 kB 164 kB +52 B (+0.0%)
- getDoc
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 135 kB 135 kB +52 B (+0.0%)
  size-with-ext-deps 194 kB 194 kB +52 B (+0.0%)
- getDocFromCache
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 90.6 kB 90.7 kB +52 B (+0.1%)
  size-with-ext-deps 150 kB 150 kB +52 B (+0.0%)
- getDocFromServer
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 135 kB 135 kB +52 B (+0.0%)
  size-with-ext-deps 194 kB 194 kB +52 B (+0.0%)
- getDocs
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 136 kB 136 kB +52 B (+0.0%)
  size-with-ext-deps 196 kB 196 kB +52 B (+0.0%)
- getDocsFromCache
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 98.3 kB 98.3 kB +52 B (+0.1%)
  size-with-ext-deps 157 kB 157 kB +52 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 136 kB 136 kB +52 B (+0.0%)
  size-with-ext-deps 196 kB 196 kB +52 B (+0.0%)
- loadBundle
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 107 kB 107 kB +52 B (+0.0%)
  size-with-ext-deps 166 kB 166 kB +52 B (+0.0%)
- namedQuery
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 84.1 kB 84.1 kB +52 B (+0.1%)
  size-with-ext-deps 143 kB 143 kB +52 B (+0.0%)
- onSnapshot
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 137 kB 137 kB +52 B (+0.0%)
  size-with-ext-deps 196 kB 197 kB +52 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 127 kB 127 kB +52 B (+0.0%)
  size-with-ext-deps 186 kB 186 kB +52 B (+0.0%)
- runTransaction
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 118 kB 118 kB +52 B (+0.0%)
  size-with-ext-deps 178 kB 178 kB +52 B (+0.0%)
- setDoc
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 117 kB 117 kB +52 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +52 B (+0.0%)
- setIndexConfiguration
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 86.7 kB 86.7 kB +52 B (+0.1%)
  size-with-ext-deps 146 kB 146 kB +52 B (+0.0%)
- updateDoc
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 118 kB 118 kB +52 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +52 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 97.9 kB 98.0 kB +52 B (+0.1%)
  size-with-ext-deps 157 kB 157 kB +52 B (+0.0%)
- writeBatch
  Size
  Type Base (d8af08f) Merge (ea9efff) Diff
  size 120 kB 120 kB +52 B (+0.0%)
  size-with-ext-deps 179 kB 179 kB +52 B (+0.0%)

Test Logs

Base (d8af08f): https://github.com/firebase/firebase-js-sdk/actions/runs/3689697834
Merge (ea9efff): https://github.com/firebase/firebase-js-sdk/actions/runs/3732931091

https://storage.googleapis.com/firebase-sdk-metric-reports/gzSJ7YYiIs.html

ehsannas · 2022-12-21T21:00:29Z

packages/firestore/src/core/filter.ts

+    // the canonical ID for these two are the same. For example:
+    // `col.whereEquals("a", 1).whereEquals("b", 2)` should have the same
+    // canonical ID as `col.where(and(equals("a",1), equals("b",2)))`.
+    return filter.filters.map(filter => canonifyFilter(filter)).join(',');


it's interesting that the canonical id of a==1 && b==1 is different strings in web and android.
In Android it'll be a==1b==1. In the Web, it'll be a==1,b==1. Nothing wrong with either one. I just checked target.ts (canonifyTarget) to make sure this is correct.

I had the same surprise. Tests caught it. Thanks for the thorough review!

MarkDuckworth added 2 commits December 16, 2022 11:24

Updated the canonical ID of flat conjunctions to match the canonical …

318d83f

…ID of old style implicit flat conjunctions.

Updated documentation of or() and and() to match the latest API docs …

bbb22b3

…in the Android implementation.

MarkDuckworth requested a review from ehsannas December 16, 2022 18:27

MarkDuckworth assigned ehsannas Dec 16, 2022

MarkDuckworth added 2 commits December 19, 2022 08:04

Formatting fix.

b0d2c7e

Create quick-radios-obey.md

76de87e

MarkDuckworth requested a review from egilmorez as a code owner December 19, 2022 15:44

ehsannas reviewed Dec 21, 2022

View reviewed changes

ehsannas approved these changes Dec 21, 2022

View reviewed changes

MarkDuckworth merged commit a7622d4 into master Dec 21, 2022

MarkDuckworth deleted the markduckworth/or-queries-4274 branch December 21, 2022 22:29

google-oss-bot mentioned this pull request Jan 17, 2023

Version Packages #6953

Merged

firebase locked and limited conversation to collaborators Jan 21, 2023

Conversation

MarkDuckworth commented Dec 16, 2022

Uh oh!

changeset-bot bot commented Dec 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

google-oss-bot commented Dec 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Dec 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/firestore

addDoc

deleteDoc

disableNetwork

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

executeWrite

getCountFromServer

getDoc

getDocFromCache

getDocFromServer

getDocs

getDocsFromCache

getDocsFromServer

loadBundle

namedQuery

onSnapshot

onSnapshotsInSync

runTransaction

setDoc

setIndexConfiguration

updateDoc

waitForPendingWrites

writeBatch

Test Logs

Uh oh!

ehsannas Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarkDuckworth Dec 21, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Dec 16, 2022 •

edited

Loading

google-oss-bot commented Dec 16, 2022 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`bundle`

`firebase`

google-oss-bot commented Dec 16, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`addDoc`

`deleteDoc`

`disableNetwork`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`executeWrite`

`getCountFromServer`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`

`getDocsFromCache`

`getDocsFromServer`

`loadBundle`

`namedQuery`

`onSnapshot`

`onSnapshotsInSync`

`runTransaction`

`setDoc`

`setIndexConfiguration`

`updateDoc`

`waitForPendingWrites`

`writeBatch`

ehsannas Dec 21, 2022 •

edited

Loading