tools: enable no-useless-return eslint rule

cjihrig · cjihrig · commit 7a4d383c7585 · 2017-04-25T12:01:55.000-04:00
PR-URL: nodejs#12577 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
diff --git a/.eslintrc.yaml b/.eslintrc.yaml
@@ -50,6 +50,7 @@ rules:
   no-unused-labels: 2
   no-useless-call: 2
   no-useless-escape: 2
+  no-useless-return: 2
   no-void: 2
   no-with: 2
 
diff --git a/doc/api/errors.md b/doc/api/errors.md
@@ -64,6 +64,7 @@ Errors that occur within _Asynchronous APIs_ may be reported in multiple ways:
   argument is not `null` and is an instance of `Error`, then an error occurred
   that should be handled.
 
+<!-- eslint-disable no-useless-return -->
   ```js
   const fs = require('fs');
   fs.readFile('a file that does not exist', (err, data) => {
diff --git a/doc/api/stream.md b/doc/api/stream.md
@@ -1566,6 +1566,7 @@ unexpected and inconsistent behavior depending on whether the stream is
 operating in flowing or paused mode. Using the `'error'` event ensures
 consistent and predictable handling of errors.
 
+<!-- eslint-disable no-useless-return -->
 ```js
 const Readable = require('stream').Readable;
 
diff --git a/lib/dgram.js b/lib/dgram.js
@@ -307,7 +307,6 @@ function enqueue(self, toEnqueue) {
     self.once('listening', onListenSuccess);
   }
   self._queue.push(toEnqueue);
-  return;
 }
 
 
diff --git a/test/parallel/test-require-symlink.js b/test/parallel/test-require-symlink.js
@@ -30,9 +30,9 @@ if (common.isWindows) {
     if (err || !o.includes('SeCreateSymbolicLinkPrivilege')) {
       common.skip('insufficient privileges');
       return;
-    } else {
-      test();
     }
+
+    test();
   });
 } else {
   test();
diff --git a/tools/doc/json.js b/tools/doc/json.js
@@ -243,7 +243,6 @@ function processList(section) {
         current.options.push(n);
         current = n;
       }
-      return;
     } else if (type === 'list_item_end') {
       if (!current) {
         throw new Error('invalid list - end without current item\n' +
@@ -516,9 +515,6 @@ function finishSection(section, parent) {
             parent[k] = parent[k].concat(section[k]);
           } else if (!parent[k]) {
             parent[k] = section[k];
-          } else {
-            // parent already has, and it's not an array.
-            return;
           }
       }
     });

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,6 @@ function enqueue(self, toEnqueue) {`
`307`	`307`	`self.once('listening', onListenSuccess);`
`308`	`308`	`}`
`309`	`309`	`self._queue.push(toEnqueue);`
`310`		`- return;`
`311`	`310`	`}`
`312`	`311`
`313`	`312`
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,6 @@ function processList(section) {`
`243`	`243`	`current.options.push(n);`
`244`	`244`	`current = n;`
`245`	`245`	`}`
`246`		`- return;`
`247`	`246`	`} else if (type === 'list_item_end') {`
`248`	`247`	`if (!current) {`
`249`	`248`	`throw new Error('invalid list - end without current item\n' +`
`@@ -516,9 +515,6 @@ function finishSection(section, parent) {`
`516`	`515`	`parent[k] = parent[k].concat(section[k]);`
`517`	`516`	`} else if (!parent[k]) {`
`518`	`517`	`parent[k] = section[k];`
`519`		`- } else {`
`520`		`- // parent already has, and it's not an array.`
`521`		`- return;`
`522`	`518`	`}`
`523`	`519`	`}`
`524`	`520`	`});`