Bug #21239299 MYSQL CRASHED BECAUSE OF FLUSH_ALL

Aditya A · Aditya A · commit db5dc6fd3abe · 2015-08-03T10:56:24.000+05:30
Function call to start transaction was called
inside the assert. Assert can be disabled by
setting NDEBUG ,which will cause this function
not to be executed and causes crashes later.

FIX
---

Call the function outside assert and do assert
on the return value.
diff --git a/plugin/innodb_memcached/innodb_memcache/src/innodb_engine.c b/plugin/innodb_memcached/innodb_memcache/src/innodb_engine.c
@@ -957,9 +957,11 @@ innodb_conn_init(
 					conn_data->crsr_trx);
 			}
 
-			assert(ib_cb_trx_start(conn_data->crsr_trx,
-					       engine->trx_level,
-					       true, false, NULL));
+			err = ib_cb_trx_start(conn_data->crsr_trx,
+					      engine->trx_level,
+					      true, false, NULL);
+			assert(err == DB_SUCCESS);
+
 		}
 
 		err = innodb_api_begin(

Original file line number	Diff line number	Diff line change
`@@ -957,9 +957,11 @@ innodb_conn_init(`
`957`	`957`	`conn_data->crsr_trx);`
`958`	`958`	`}`
`959`	`959`
`960`		`- assert(ib_cb_trx_start(conn_data->crsr_trx,`
`961`		`- engine->trx_level,`
`962`		`- true, false, NULL));`
	`960`	`+ err = ib_cb_trx_start(conn_data->crsr_trx,`
	`961`	`+ engine->trx_level,`
	`962`	`+ true, false, NULL);`
	`963`	`+ assert(err == DB_SUCCESS);`
	`964`	`+`
`963`	`965`	`}`
`964`	`966`
`965`	`967`	`err = innodb_api_begin(`