Add missing @OVERRIDES and enforce this rule

mrigger · mrigger · commit e702d281db61 · 2020-05-27T23:31:46.000+02:00
diff --git a/pmd-rules.xml b/pmd-rules.xml
@@ -18,6 +18,16 @@
 		<exclude name="WhileLoopWithLiteralBoolean" /> 
 		<exclude name="AvoidReassigningParameters" />
 		<exclude name="UnusedFormalParameter" />
+		<exclude name="PositionLiteralsFirstInComparisons" />
+		<exclude name="ForLoopCanBeForeach" />
+		<exclude name="ArrayIsStoredDirectly" />
+		<exclude name="MethodReturnsInternalArray" />
+		<exclude name="CheckResultSet" />
+		<exclude name="UseVarargs" />
+		<exclude name="UseTryWithResources" />
+		<exclude name="AvoidReassigningLoopVariables" />
+		<exclude name="AbstractClassWithoutAbstractMethod" />
+		<priority>2</priority>
 	</rule>
 	
 
diff --git a/src/sqlancer/postgres/ast/PostgresBinaryArithmeticOperation.java b/src/sqlancer/postgres/ast/PostgresBinaryArithmeticOperation.java
@@ -75,6 +75,7 @@ private static PostgresConstant applyBitOperation(PostgresConstant left, Postgre
             this.textRepresentation = textRepresentation;
         }
 
+        @Override
         public String getTextRepresentation() {
             return textRepresentation;
         }
diff --git a/src/sqlancer/postgres/ast/PostgresBinaryComparisonOperation.java b/src/sqlancer/postgres/ast/PostgresBinaryComparisonOperation.java
@@ -99,6 +99,7 @@ public PostgresConstant getExpectedValue(PostgresConstant leftVal, PostgresConst
 
         private final String textRepresentation;
 
+        @Override
         public String getTextRepresentation() {
             return textRepresentation;
         }

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ private static PostgresConstant applyBitOperation(PostgresConstant left, Postgre`
`75`	`75`	`this.textRepresentation = textRepresentation;`
`76`	`76`	`}`
`77`	`77`
	`78`	`+ @Override`
`78`	`79`	`public String getTextRepresentation() {`
`79`	`80`	`return textRepresentation;`
`80`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ public PostgresConstant getExpectedValue(PostgresConstant leftVal, PostgresConst`
`99`	`99`
`100`	`100`	`private final String textRepresentation;`
`101`	`101`
	`102`	`+ @Override`
`102`	`103`	`public String getTextRepresentation() {`
`103`	`104`	`return textRepresentation;`
`104`	`105`	`}`