Fix to bug that alters subquery columns in Citus subquery joins

nukoyluoglu · nukoyluoglu · commit e499f99e4e63 · 2020-08-21T18:29:57.000+03:00
diff --git a/src/sqlancer/citus/oracle/tlp/CitusTLPBase.java b/src/sqlancer/citus/oracle/tlp/CitusTLPBase.java
@@ -208,11 +208,12 @@ private void addSubqueryJoinStatements(PostgresGlobalState globalState, List<Pos
         // JOIN with subquery
         for (int i = 0; i < Randomly.smallNumber(); i++) {
             PostgresTables subqueryTables = new PostgresTables(Randomly.nonEmptySubset(localTables));
-            List<PostgresColumn> columns = subqueryTables.getColumns();
+            List<PostgresColumn> columns = new ArrayList<>();
+            columns.addAll(subqueryTables.getColumns());
             columns.addAll(fromTable.getColumns());
+            PostgresExpression subquery = createSubquery(globalState, String.format("sub%d", i), subqueryTables);
             PostgresExpressionGenerator subqueryJoinGen = new PostgresExpressionGenerator(globalState)
                     .setColumns(columns);
-            PostgresExpression subquery = createSubquery(globalState, String.format("sub%d", i), subqueryTables);
             PostgresExpression joinClause = subqueryJoinGen.generateExpression(PostgresDataType.BOOLEAN);
             PostgresJoinType options = PostgresJoinType.getRandom();
             PostgresJoin j = new PostgresJoin(subquery, joinClause, options);
