Remove redundant String.valueOf invocations

mrigger · mrigger · commit df3c4b2d873d · 2020-07-01T23:00:29.000+02:00
diff --git a/configs/pmd-rules.xml b/configs/pmd-rules.xml
@@ -82,7 +82,6 @@
 		<exclude name="InsufficientStringBufferDeclaration" />
 		<exclude name="RedundantFieldInitializer" />
 		<exclude name="ConsecutiveAppendsShouldReuse" />
-		<exclude name="UselessStringValueOf" />
 		<exclude name="UseStringBufferForStringAppends" />
 		<exclude name="SimplifyStartsWith" />
 		<exclude name="TooFewBranchesForASwitchStatement" />
diff --git a/src/sqlancer/postgres/ast/PostgresConstant.java b/src/sqlancer/postgres/ast/PostgresConstant.java
@@ -464,7 +464,7 @@ public String getTextRepresentation() {
             if (Double.isFinite(val)) {
                 return String.valueOf(val);
             } else {
-                return "'" + String.valueOf(val) + "'";
+                return "'" + val + "'";
             }
         }
 
@@ -488,7 +488,7 @@ public String getTextRepresentation() {
             if (Double.isFinite(val)) {
                 return String.valueOf(val);
             } else {
-                return "'" + String.valueOf(val) + "'";
+                return "'" + val + "'";
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -464,7 +464,7 @@ public String getTextRepresentation() {`
`464`	`464`	`if (Double.isFinite(val)) {`
`465`	`465`	`return String.valueOf(val);`
`466`	`466`	`} else {`
`467`		`- return "'" + String.valueOf(val) + "'";`
	`467`	`+ return "'" + val + "'";`
`468`	`468`	`}`
`469`	`469`	`}`
`470`	`470`
`@@ -488,7 +488,7 @@ public String getTextRepresentation() {`
`488`	`488`	`if (Double.isFinite(val)) {`
`489`	`489`	`return String.valueOf(val);`
`490`	`490`	`} else {`
`491`		`- return "'" + String.valueOf(val) + "'";`
	`491`	`+ return "'" + val + "'";`
`492`	`492`	`}`
`493`	`493`	`}`
`494`	`494`