[TiDB] Introduce a bug workaround class

mrigger · mrigger · commit 8c93a2268ec8 · 2020-04-05T15:13:34.000+02:00
diff --git a/src/sqlancer/tidb/TiDBBugs.java b/src/sqlancer/tidb/TiDBBugs.java
@@ -0,0 +1,25 @@
+package sqlancer.tidb;
+
+public class TiDBBugs {
+	
+	// https://github.com/pingcap/tidb/issues/15987
+	public static boolean BUG_15987 = true;
+
+	// // https://github.com/pingcap/tidb/issues/15988
+	public static boolean BUG_15988 = true;
+
+	//  https://github.com/pingcap/tidb/issues/15994
+	public static boolean BUG_15994 = true;
+
+	// https://github.com/pingcap/tidb/issues/16028
+	public static boolean BUG_16028 = true;
+	
+	// https://github.com/pingcap/tidb/issues/16020
+	public static boolean BUG_16020 = true;
+
+	// https://github.com/pingcap/tidb/issues/15990
+	public static boolean BUG_15990 = true;
+	
+	
+
+}
diff --git a/src/sqlancer/tidb/TiDBExpressionGenerator.java b/src/sqlancer/tidb/TiDBExpressionGenerator.java
@@ -78,8 +78,7 @@ protected TiDBExpression generateExpression(int depth) {
 		case REGEX:
 			return new TiDBRegexOperation(generateExpression(depth + 1), generateExpression(depth + 1), TiDBRegexOperator.getRandom());
 		case COLLATE:
-			if (true) {
-				// https://github.com/pingcap/tidb/issues/15988
+			if (TiDBBugs.BUG_15988) {
 				throw new IgnoreMeException();
 			}
 			return new TiDBCollate(generateExpression(depth + 1), Randomly.fromOptions("utf8mb4_bin", "latin1_bin", "binary", "ascii_bin", "utf8_bin"));
@@ -89,9 +88,7 @@ protected TiDBExpression generateExpression(int depth) {
 		case BINARY_BIT:
 			return new TiDBBinaryBitOperation(generateExpression(depth + 1), generateExpression(depth + 1), TiDBBinaryBitOperator.getRandom());
 		case BINARY_LOGICAL:
-			if (true) {
-				// https://github.com/pingcap/tidb/issues/15990
-				// https://github.com/pingcap/tidb/issues/15987
+			if (TiDBBugs.BUG_15987 || TiDBBugs.BUG_15990) {
 				throw new IgnoreMeException();
 			}
 			return new TiDBBinaryLogicalOperation(generateExpression(depth + 1), generateExpression(depth + 1), TiDBBinaryLogicalOperator.getRandom());
diff --git a/src/sqlancer/tidb/gen/TiDBTableGenerator.java b/src/sqlancer/tidb/gen/TiDBTableGenerator.java
@@ -10,6 +10,7 @@
 import sqlancer.Query;
 import sqlancer.QueryAdapter;
 import sqlancer.Randomly;
+import sqlancer.tidb.TiDBBugs;
 import sqlancer.tidb.TiDBExpressionGenerator;
 import sqlancer.tidb.TiDBProvider.TiDBGlobalState;
 import sqlancer.tidb.TiDBSchema.TiDBColumn;
@@ -49,7 +50,7 @@ public Query getQuery(TiDBGlobalState globalState) throws SQLException {
 			appendSizeSpecifiers(sb, type);
 			sb.append(" ");
 			boolean isGeneratedColumn = Randomly.getBooleanWithRatherLowProbability();
-			if (isGeneratedColumn && false /* https://github.com/pingcap/tidb/issues/16020, https://github.com/pingcap/tidb/issues/15994 */) {
+			if (isGeneratedColumn && !TiDBBugs.BUG_15994 & !TiDBBugs.BUG_16020) {
 				sb.append(" AS (");
 				sb.append(TiDBVisitor.asString(gen.generateExpression()));
 				sb.append(") ");
@@ -98,10 +99,10 @@ public Query getQuery(TiDBGlobalState globalState) throws SQLException {
 	}
 
 	private void appendSizeSpecifiers(StringBuilder sb, TiDBDataType type) {
-		if (type.isNumeric() && Randomly.getBoolean() && false /* https://github.com/pingcap/tidb/issues/16028 */) {
+		if (type.isNumeric() && Randomly.getBoolean() && !TiDBBugs.BUG_16028) {
 			sb.append(" UNSIGNED");
 		}
-		if (type.isNumeric() && Randomly.getBoolean() && false /* seems to be the same bug as https://github.com/pingcap/tidb/issues/16028 */) {
+		if (type.isNumeric() && Randomly.getBoolean() && !TiDBBugs.BUG_16028 /* seems to be the same bug as https://github.com/pingcap/tidb/issues/16028 */) {
 			sb.append(" ZEROFILL");
 		}		
 	}
