Enable the PMD FormalParameterNamingConventions rule and fix warnings

mrigger · mrigger · commit 677daca623b1 · 2020-07-03T09:39:18.000+02:00
diff --git a/configs/pmd-rules.xml b/configs/pmd-rules.xml
@@ -45,7 +45,6 @@
 
 		<!-- TODO -->
 		<exclude name="ShortClassName" />
-		<exclude name="FormalParameterNamingConventions" />
 		<exclude name="LinguisticNaming" />
 		<exclude name="ConfusingTernary" />
 		<exclude name="PrematureDeclaration" />
diff --git a/src/sqlancer/postgres/gen/PostgresCommon.java b/src/sqlancer/postgres/gen/PostgresCommon.java
@@ -197,7 +197,7 @@ private enum StorageParameters {
         PARALLEL_WORKERS("parallel_workers", (r) -> r.getInteger(0, 1024)),
         AUTOVACUUM_ENABLED("autovacuum_enabled", (r) -> Randomly.fromOptions(0, 1)),
         AUTOVACUUM_VACUUM_THRESHOLD("autovacuum_vacuum_threshold", (r) -> r.getInteger(0, 2147483647)),
-        OIDS("oids", (R) -> Randomly.fromOptions(0, 1)),
+        OIDS("oids", (r) -> Randomly.fromOptions(0, 1)),
         AUTOVACUUM_VACUUM_SCALE_FACTOR("autovacuum_vacuum_scale_factor",
                 (r) -> Randomly.fromOptions(0, 0.00001, 0.01, 0.1, 0.2, 0.5, 0.8, 0.9, 1)),
         AUTOVACUUM_ANALYZE_THRESHOLD("autovacuum_analyze_threshold", (r) -> r.getLong(0, Integer.MAX_VALUE)),
