Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Fix: @Nullable annotations on builder methods #3222

Merged
PhongChuong merged 5 commits into from
Apr 24, 2024
Merged

Fix: @Nullable annotations on builder methods #3222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b730fd
Fix @Nullable annotations on builder methods
cushon Mar 29, 2024
177870d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 17, 2024
3e3a943
Review comments
cushon Apr 22, 2024
c0e8000
Review comments
cushon Apr 23, 2024
2ccfa96
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,20 @@ If you are using Maven without the BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.34.0')
implementation platform('com.google.cloud:libraries-bom:26.37.0')

implementation 'com.google.cloud:google-cloud-bigquery'
```
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-bigquery:2.38.2'
implementation 'com.google.cloud:google-cloud-bigquery:2.39.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery" % "2.38.2"
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery" % "2.39.0"
```
<!-- {x-version-update-end} -->

Expand Down Expand Up @@ -351,7 +351,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigquery/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-bigquery.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-bigquery/2.38.2
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-bigquery/2.39.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
1 change: 0 additions & 1 deletion google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ Builder withDefaultValues() {
*
* @param useReadAPI or {@code true} for none
*/
@Nullable
public abstract Builder setUseReadAPI(Boolean useReadAPI);

/**
Expand Down
6 changes: 3 additions & 3 deletions ...d-bigquery/src/main/java/com/google/cloud/bigquery/ReadClientConnectionConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,34 +31,34 @@ public abstract static class Builder {
* Sets the total row count to page row count ratio used to determine whether to us the
* BigQueryStorage Read client to fetch result sets after the first page.
*/
@Nullable
public abstract Builder setTotalToPageRowCountRatio(Long ratio);
Comment thread
PhongChuong marked this conversation as resolved.

/**
* Sets the minimum number of table rows in the query results used to determine whether to us
* the BigQueryStorage Read client to fetch result sets after the first page.
*/
@Nullable
public abstract Builder setMinResultSize(Long numRows);
Comment thread
PhongChuong marked this conversation as resolved.

/**
* Sets the maximum number of table rows allowed in buffer before streaming them to the
* BigQueryResult.
*/
@Nullable
public abstract Builder setBufferSize(Long bufferSize);
Comment thread
PhongChuong marked this conversation as resolved.

/** Creates a {@code ReadClientConnectionConfiguration} object. */
public abstract ReadClientConnectionConfiguration build();
}

/** Returns the totalToPageRowCountRatio in this configuration. */
@Nullable
public abstract Long getTotalToPageRowCountRatio();

/** Returns the minResultSize in this configuration. */
@Nullable
public abstract Long getMinResultSize();

/** Returns the bufferSize in this configuration. */
@Nullable
public abstract Long getBufferSize();

public abstract Builder toBuilder();
Expand Down