Skip to content

Commit b2e7426

Browse files
khorshuhengkhorshuheng
authored
add support for redis auth (#106)
* add support for redis auth Signed-off-by: Khor Shu Heng <[email protected]> * use setup.py Signed-off-by: Khor Shu Heng <[email protected]> * remove gcp and aws e2e Signed-off-by: Khor Shu Heng <[email protected]> * rename auth to password for clarity Signed-off-by: Khor Shu Heng <[email protected]>
1 parent ecd77c8 commit b2e7426

11 files changed

Lines changed: 40 additions & 379 deletions

File tree

‎.prow.yaml‎

Lines changed: 0 additions & 249 deletions
Original file line numberDiff line numberDiff line change
@@ -1,66 +1,4 @@
11
presubmits:
2-
- name: test-end-to-end-gcp
3-
decorate: true
4-
always_run: true
5-
max_concurrency: 1
6-
spec:
7-
containers:
8-
- image: gcr.io/kf-feast/feast-ci:latest
9-
command: [ "infra/scripts/test-end-to-end-gcp.sh" ]
10-
resources:
11-
requests:
12-
cpu: "6"
13-
memory: "6144Mi"
14-
env:
15-
- name: GOOGLE_APPLICATION_CREDENTIALS
16-
value: /etc/gcloud/service-account.json
17-
volumeMounts:
18-
- mountPath: /etc/gcloud/service-account.json
19-
name: service-account
20-
readOnly: true
21-
subPath: service-account.json
22-
volumes:
23-
- name: service-account
24-
secret:
25-
secretName: feast-service-account
26-
- name: test-end-to-end-aws
27-
decorate: true
28-
always_run: true
29-
max_concurrency: 1
30-
spec:
31-
containers:
32-
- image: gcr.io/kf-feast/feast-ci:latest
33-
command: [ "infra/scripts/aws-runner.sh", "--location-from-prow", "--project-name", "feast-ci-project" ]
34-
resources:
35-
requests:
36-
cpu: "2"
37-
memory: "2Gi"
38-
env:
39-
- name: GOOGLE_APPLICATION_CREDENTIALS
40-
value: /etc/gcloud/service-account.json
41-
- name: DOCKER_REPOSITORY
42-
value: gcr.io/kf-feast
43-
- name: AWS_ACCESS_KEY_ID
44-
valueFrom:
45-
secretKeyRef:
46-
name: feast-aws-creds
47-
key: AWS_ACCESS_KEY_ID
48-
- name: AWS_SECRET_ACCESS_KEY
49-
valueFrom:
50-
secretKeyRef:
51-
name: feast-aws-creds
52-
key: AWS_SECRET_ACCESS_KEY
53-
- name: AWS_DEFAULT_REGION
54-
value: us-west-2
55-
volumeMounts:
56-
- mountPath: /etc/gcloud/service-account.json
57-
name: service-account
58-
readOnly: true
59-
subPath: service-account.json
60-
volumes:
61-
- name: service-account
62-
secret:
63-
secretName: feast-service-account
642
- name: test-end-to-end-sparkop
653
decorate: true
664
always_run: true
@@ -90,134 +28,7 @@ presubmits:
9028
secret:
9129
secretName: feast-service-account
9230

93-
94-
#- name: test-end-to-end-azure
95-
# decorate: true
96-
# always_run: true
97-
# max_concurrency: 1
98-
# spec:
99-
# containers:
100-
# - image: gcr.io/kf-feast/feast-ci:develop
101-
# command: [ "infra/scripts/azure-runner.sh" ]
102-
# resources:
103-
# requests:
104-
# cpu: "2"
105-
# memory: "2048Mi"
106-
# env:
107-
# - name: GOOGLE_APPLICATION_CREDENTIALS
108-
# value: /etc/gcloud/service-account.json
109-
# - name: RESOURCE_GROUP
110-
# value: Feast
111-
# - name: AKS_CLUSTER_NAME
112-
# value: main
113-
# - name: DOCKER_REPOSITORY
114-
# value: gcr.io/kf-feast
115-
# - name: STAGING_PATH
116-
# value: wasbs://[email protected]/cicd-staging
117-
# - name: AZ_SERVICE_PRINCIPAL_ID
118-
# valueFrom:
119-
# secretKeyRef:
120-
# name: feast-az-creds
121-
# key: AZ_SERVICE_PRINCIPAL_ID
122-
# - name: AZ_SERVICE_PRINCIPAL_PASS
123-
# valueFrom:
124-
# secretKeyRef:
125-
# name: feast-az-creds
126-
# key: AZ_SERVICE_PRINCIPAL_PASS
127-
# - name: AZ_SERVICE_PRINCIPAL_TENANT_ID
128-
# valueFrom:
129-
# secretKeyRef:
130-
# name: feast-az-creds
131-
# key: AZ_SERVICE_PRINCIPAL_TENANT_ID
132-
# - name: AZURE_BLOB_ACCOUNT_NAME
133-
# valueFrom:
134-
# secretKeyRef:
135-
# name: feast-az-creds
136-
# key: AZURE_BLOB_ACCOUNT_NAME
137-
# - name: AZURE_BLOB_ACCOUNT_ACCESS_KEY
138-
# valueFrom:
139-
# secretKeyRef:
140-
# name: feast-az-creds
141-
# key: AZURE_BLOB_ACCOUNT_ACCESS_KEY
142-
# volumeMounts:
143-
# - mountPath: /etc/gcloud/service-account.json
144-
# name: service-account
145-
# readOnly: true
146-
# subPath: service-account.json
147-
# volumes:
148-
# - name: service-account
149-
# secret:
150-
# secretName: feast-service-account
151-
15231
postsubmits:
153-
- name: test-end-to-end-gcp
154-
decorate: true
155-
always_run: true
156-
max_concurrency: 1
157-
branches:
158-
- ^master$
159-
spec:
160-
containers:
161-
- image: gcr.io/kf-feast/feast-ci:latest
162-
command: [ "infra/scripts/test-end-to-end-gcp.sh" ]
163-
resources:
164-
requests:
165-
cpu: "6"
166-
memory: "6144Mi"
167-
env:
168-
- name: GOOGLE_APPLICATION_CREDENTIALS
169-
value: /etc/gcloud/service-account.json
170-
volumeMounts:
171-
- mountPath: /etc/gcloud/service-account.json
172-
name: service-account
173-
readOnly: true
174-
subPath: service-account.json
175-
volumes:
176-
- name: service-account
177-
secret:
178-
secretName: feast-service-account
179-
180-
- name: test-end-to-end-aws
181-
decorate: true
182-
always_run: true
183-
max_concurrency: 1
184-
branches:
185-
- ^master$
186-
spec:
187-
containers:
188-
- image: gcr.io/kf-feast/feast-ci:latest
189-
command: [ "infra/scripts/aws-runner.sh", "--location-from-prow", "--project-name", "feast-ci-project" ]
190-
resources:
191-
requests:
192-
cpu: "2"
193-
memory: "2048Mi"
194-
env:
195-
- name: GOOGLE_APPLICATION_CREDENTIALS
196-
value: /etc/gcloud/service-account.json
197-
- name: DOCKER_REPOSITORY
198-
value: gcr.io/kf-feast
199-
- name: AWS_ACCESS_KEY_ID
200-
valueFrom:
201-
secretKeyRef:
202-
name: feast-aws-creds
203-
key: AWS_ACCESS_KEY_ID
204-
- name: AWS_SECRET_ACCESS_KEY
205-
valueFrom:
206-
secretKeyRef:
207-
name: feast-aws-creds
208-
key: AWS_SECRET_ACCESS_KEY
209-
- name: AWS_DEFAULT_REGION
210-
value: us-west-2
211-
volumeMounts:
212-
- mountPath: /etc/gcloud/service-account.json
213-
name: service-account
214-
readOnly: true
215-
subPath: service-account.json
216-
volumes:
217-
- name: service-account
218-
secret:
219-
secretName: feast-service-account
220-
22132
- name: test-end-to-end-sparkop
22233
decorate: true
22334
always_run: true
@@ -248,63 +59,3 @@ postsubmits:
24859
- name: service-account
24960
secret:
25061
secretName: feast-service-account
251-
252-
#- name: test-end-to-end-azure
253-
# decorate: true
254-
# always_run: true
255-
# max_concurrency: 1
256-
# branches:
257-
# - ^master$
258-
# spec:
259-
# containers:
260-
# - image: gcr.io/kf-feast/feast-ci:develop
261-
# command: [ "infra/scripts/azure-runner.sh" ]
262-
# resources:
263-
# requests:
264-
# cpu: "2"
265-
# memory: "2048Mi"
266-
# env:
267-
# - name: GOOGLE_APPLICATION_CREDENTIALS
268-
# value: /etc/gcloud/service-account.json
269-
# - name: RESOURCE_GROUP
270-
# value: Feast
271-
# - name: AKS_CLUSTER_NAME
272-
# value: main
273-
# - name: DOCKER_REPOSITORY
274-
# value: gcr.io/kf-feast
275-
# - name: STAGING_PATH
276-
# value: wasbs://[email protected]/cicd-staging
277-
# - name: AZ_SERVICE_PRINCIPAL_ID
278-
# valueFrom:
279-
# secretKeyRef:
280-
# name: feast-az-creds
281-
# key: AZ_SERVICE_PRINCIPAL_ID
282-
# - name: AZ_SERVICE_PRINCIPAL_PASS
283-
# valueFrom:
284-
# secretKeyRef:
285-
# name: feast-az-creds
286-
# key: AZ_SERVICE_PRINCIPAL_PASS
287-
# - name: AZ_SERVICE_PRINCIPAL_TENANT_ID
288-
# valueFrom:
289-
# secretKeyRef:
290-
# name: feast-az-creds
291-
# key: AZ_SERVICE_PRINCIPAL_TENANT_ID
292-
# - name: AZURE_BLOB_ACCOUNT_NAME
293-
# valueFrom:
294-
# secretKeyRef:
295-
# name: feast-az-creds
296-
# key: AZURE_BLOB_ACCOUNT_NAME
297-
# - name: AZURE_BLOB_ACCOUNT_ACCESS_KEY
298-
# valueFrom:
299-
# secretKeyRef:
300-
# name: feast-az-creds
301-
# key: AZURE_BLOB_ACCOUNT_ACCESS_KEY
302-
# volumeMounts:
303-
# - mountPath: /etc/gcloud/service-account.json
304-
# name: service-account
305-
# readOnly: true
306-
# subPath: service-account.json
307-
# volumes:
308-
# - name: service-account
309-
# secret:
310-
# secretName: feast-service-account

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ install-python-ci-dependencies:
3434

3535
# Supports feast-dev repo master branch
3636
install-python: install-python-ci-dependencies
37-
cd ${ROOT_DIR}; python -m pip install -e python
37+
cd ${ROOT_DIR}/python; python setup.py install
3838

3939
lint-python:
4040
cd ${ROOT_DIR}/python ; mypy feast_spark/ tests/

‎infra/scripts/test-end-to-end-aws.sh‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

‎infra/scripts/test-end-to-end-azure.sh‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)