fix: Handle empty query in execute_snowflake_statement#6249
Open
jials wants to merge 1 commit intofeast-dev:masterfrom
Open
fix: Handle empty query in execute_snowflake_statement#6249jials wants to merge 1 commit intofeast-dev:masterfrom
jials wants to merge 1 commit intofeast-dev:masterfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Signed-off-by: Jia Le <[email protected]>
jials
force-pushed
the
fix/empty-snowflake-query
branch
from
5c4ea01 to
22c94b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an early return in execute_snowflake_statement when the query string is empty or whitespace-only. Previously, passing an empty query would attempt to execute it against Snowflake, resulting in error. Now it returns a cursor without executing.
Which issue(s) this PR fixes:
Fixes #5204
Checks
git commit -s)Testing Strategy
Misc