v0.3 backport: Remove unused ingestion deps#521
Merged
ches merged 2 commits intofeast-dev:v0.3-branchfrom Mar 9, 2020
Merged
Conversation
ches
added
kind/housekeeping
area/ingestion
ches
requested review from
davidheryanto,
pradithya,
thirteen37,
woop and
zhilingc
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ches The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/assign @thirteen37 |
Member
Author
Unused according to `mvn -pl ingestion dependency:analyze`, and tests. We had a recent bump of hibernate-validator with a CVE fix (feast-dev#421) that I was looking to backport, and it turns out it's not used anymore anyway.
ches
force-pushed
the
v0.3-backport-520-unused-deps
branch
from
4b46b6d to
5b7085f
Compare
Member
Author
|
Going to proceed with this one to get it into a batch of things merging to our internal mainline. Pretty trivial backport passing the build so I think it's uncontroversial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backports #520 to
v0.3-branch—as noted on #520, this is to alleviate a vulnerability warning for the version ofhibernate-validatorin this maintenance branch, though in fact the dependency is unused so can be removed entirely.Does this PR introduce a user-facing change?: