feat: Adding volumes and volumeMounts support to Feature Store CR. by lokeshrangineni · Pull Request #4983 · feast-dev/feast

lokeshrangineni · 2025-01-29T20:40:50Z

What this PR does / why we need it:

This PR is adding support to add Volumes and volumeMounts to the FeatureStore custom resource in go operator code.

Which issue(s) this PR fixes:

4994

Misc

tchughesiv

some initial thoughts

infra/feast-operator/api/v1alpha1/featurestore_types.go

infra/feast-operator/internal/controller/services/services.go

infra/feast-operator/api/v1alpha1/featurestore_types.go

infra/feast-operator/internal/controller/featurestore_controller_test_utils_test.go

infra/feast-operator/internal/controller/services/services.go

tchughesiv

wasn't one of the use-cases for this feature to support data store tls? it might be good to have a sample in config/samples demonstrating what it might look like to use postgres w/ tls using this new feature...

infra/feast-operator/internal/controller/services/services.go

tchughesiv · 2025-02-05T17:44:37Z

@lokeshrangineni please rebase

lokeshrangineni · 2025-02-07T02:44:10Z

wasn't one of the use-cases for this feature to support data store tls? it might be good to have a sample in config/samples demonstrating what it might look like to use postgres w/ tls using this new feature...

I have provided a working sample here

infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_ssl.yaml

lokeshrangineni · 2025-02-07T15:12:15Z

@tchughesiv - Great feedback. I have incorporated all the review comments. PTAL whenever you have some time.

Signed-off-by: lrangine <[email protected]>

tchughesiv

now that you've rebased, we should be able to further simplify the sample CR

infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_ssl.yaml

infra/feast-operator/internal/controller/services/services.go

infra/feast-operator/internal/controller/featurestore_controller_volume_volumemount_test.go

Signed-off-by: lrangine <[email protected]>

tchughesiv

the whole reason for creating the secret and then specifying...

          envFrom:
            - secretRef:
                name: postgres-secret

is to use the secret key/values as env vars within the container.

infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_ssl.yaml

infra/feast-operator/internal/controller/services/services.go

Signed-off-by: lrangine <[email protected]>

tchughesiv

lgtm

# [0.46.0](v0.45.0...v0.46.0) (2025-02-17) ### Bug Fixes * Add scylladb to online stores list in docs ([#5061](#5061)) ([08183ed](08183ed)) * Changed feast operator to set status of featurestore cr to ready based on deployment.status = available ([#5020](#5020)) ([fce0d35](fce0d35)) * Ensure Postgres queries are committed or autocommit is used ([#5039](#5039)) ([46f8d7a](46f8d7a)) * Fixing the release workflow to refresh the stable branch when the release is not running in the dry run mode. ([#5057](#5057)) ([a13fa9b](a13fa9b)) * Operator - make onlineStore the default service ([#5044](#5044)) ([6c92447](6c92447)) * Operator - resolve infinite reconciler loop in authz controller ([#5056](#5056)) ([11e4548](11e4548)) * Resolve module on windows ([#4827](#4827)) ([efbffa4](efbffa4)) * Setting the github_token explicitly to see if that solves the problem. ([#5012](#5012)) ([3834ffa](3834ffa)) * Validate entities when running get_online_features ([#5031](#5031)) ([3bb0dca](3bb0dca)) ### Features * Add SQLite retrieve_online_documents_v2 ([#5032](#5032)) ([0fffe21](0fffe21)) * Adding Click command to display configuration details ([#5036](#5036)) ([ae68e4d](ae68e4d)) * Adding volumes and volumeMounts support to Feature Store CR. ([#4983](#4983)) ([ec6f1b7](ec6f1b7)) * Moving the job to seperate action so that we can test it easily. ([#5013](#5013)) ([b9325b7](b9325b7)) * Operator - make server container creation explicit in the CR ([#5024](#5024)) ([b16fb40](b16fb40))

lokeshrangineni added the ok-to-test label Jan 29, 2025

lokeshrangineni changed the title ~~Initial draft version to add volumes and volumeMounts options.~~ feat: Initial draft version to add volumes and volumeMounts options. Jan 29, 2025

tchughesiv requested changes Jan 29, 2025

View reviewed changes

lokeshrangineni force-pushed the feature/volume-support-new branch from 733241b to 348ec68 Compare January 29, 2025 23:31

tchughesiv reviewed Jan 30, 2025

View reviewed changes

infra/feast-operator/internal/controller/featurestore_controller_test_utils_test.go Outdated Show resolved Hide resolved

tchughesiv requested changes Jan 30, 2025

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

lokeshrangineni marked this pull request as ready for review January 31, 2025 04:13

lokeshrangineni requested a review from a team as a code owner January 31, 2025 04:13

lokeshrangineni changed the title ~~feat: Initial draft version to add volumes and volumeMounts options.~~ feat: Adding volumes and volumeMounts support to Feature Store CR. Jan 31, 2025

tchughesiv reviewed Jan 31, 2025

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

tchughesiv reviewed Jan 31, 2025

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

lokeshrangineni marked this pull request as draft January 31, 2025 17:26

lokeshrangineni force-pushed the feature/volume-support-new branch 2 times, most recently from 82d407b to 9f9263e Compare February 5, 2025 20:56

lokeshrangineni marked this pull request as ready for review February 7, 2025 02:44

tchughesiv requested changes Feb 7, 2025

View reviewed changes

lokeshrangineni force-pushed the feature/volume-support-new branch 2 times, most recently from bc902db to 5ea2b6b Compare February 7, 2025 19:58

lokeshrangineni added 2 commits February 7, 2025 15:07

Squashed volume and volumeMounts commits for rebase

9ed3c41

Signed-off-by: lrangine <[email protected]>

resolving master rebase conflicts.

cd431ab

Signed-off-by: lrangine <[email protected]>

lokeshrangineni force-pushed the feature/volume-support-new branch from 5ea2b6b to cd431ab Compare February 7, 2025 20:11

tchughesiv requested changes Feb 7, 2025

View reviewed changes

infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_ssl.yaml Outdated Show resolved Hide resolved

tchughesiv reviewed Feb 7, 2025

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

tchughesiv reviewed Feb 7, 2025

View reviewed changes

infra/feast-operator/internal/controller/featurestore_controller_volume_volumemount_test.go Outdated Show resolved Hide resolved

lokeshrangineni added 2 commits February 7, 2025 15:29

resolving master rebase conflicts. few more missing files.

fee432d

Signed-off-by: lrangine <[email protected]>

Modifying the sample file as per the new code changes.

9c237ca

Signed-off-by: lrangine <[email protected]>

Modifying the sample file as per the new code changes.

3d239a6

Signed-off-by: lrangine <[email protected]>

tchughesiv requested changes Feb 7, 2025

View reviewed changes

infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_ssl.yaml Outdated Show resolved Hide resolved

infra/feast-operator/config/samples/v1alpha1_featurestore_postgres_db_volumes_ssl.yaml Outdated Show resolved Hide resolved

tchughesiv requested changes Feb 7, 2025

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

incorporating code review comments.

77fe297

Signed-off-by: lrangine <[email protected]>

tchughesiv approved these changes Feb 7, 2025

View reviewed changes

tchughesiv merged commit ec6f1b7 into feast-dev:master Feb 7, 2025

Conversation

lokeshrangineni commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv commented Feb 5, 2025

Uh oh!

lokeshrangineni commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lokeshrangineni commented Feb 7, 2025

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lokeshrangineni commented Jan 29, 2025 •

edited

Loading

tchughesiv left a comment •

edited

Loading