Fix branch inconsistency#472
Merged
davidheryanto merged 11 commits intofeast-dev:v0.4-branchfrom Feb 13, 2020
Merged
Conversation
* Initial commit of changelog up to 0.4.3 * Remove unreleased changes on master * Add missing changelog manually Co-authored-by: Khor Shu Heng <[email protected]>
Rather than the Maven protobuf plugin running on the same symlinked definitions in several Java modules, localize this process into one module that the others depend on. This provides a single module that can be depended on by third-party extensions with the bare minimum of dependencies. Also removes proto files that are no longer used.
* Add documentation for bigquery batch retrieval * Fix formatting for multiline comments
…on (feast-dev#421) Bumps [hibernate-validator](https://github.com/hibernate/hibernate-validator) from 6.0.13.Final to 6.1.0.Final. - [Release notes](https://github.com/hibernate/hibernate-validator/releases) - [Changelog](https://github.com/hibernate/hibernate-validator/blob/master/changelog.txt) - [Commits](hibernate/hibernate-validator@6.0.13.Final...6.1.0.Final) Signed-off-by: dependabot[bot] <[email protected]>
This forward-ports a straggling commit from feast-dev#407: it was missed when initially creating the datatypes module because Sonatype publishing setup was added concurrently.
Allow log level to be set via environmental variable. Add ability to set appender type in serving. Remove logback-classic from ingestion as it is a library so should not bring its own impl. Upgrade log4j to 2.12.1 to support objectMessageAsJsonObject. Fix logger config targeting feast package in serving an add same concept for core.
* Update Changelog * Remove closed issues
khorshuheng
requested review from
davidheryanto,
pradithya,
woop and
zhilingc
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: khorshuheng The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
/retest |
Collaborator
|
/retest |
Collaborator
|
All tests for Java 8 related passed. Merging manually because the failing tests are for java 11 when the prow config has not been updated to igore those tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR back port bug fixes from master branch back to branch v0.4 (up to release 0.4.4). The commit differences were generated via:
git log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr)%Creset' --abbrev-commit --date=relative v0.4-branch..v0.4.4Patches to be included in v0.4.5 will be committed via another PR.
The commits which has been cherry picked:
These commits will be left out: