Conversation
Move prometheus-statsd-exporter to toggleable core dependency (default false). Add ingresses for gRPC and HTTP for both core and serving. Refactor ConfigMaps to user Spring profiles rather than manipulating the base application.yaml. Add ability to define and enable arbitrary Spring profiles. Add toggle to enable prometheus scraping in core. Add parameters to change LOG_LEVEL and LOG_TYPE (feast-dev#430). Add parameter to specify GOOGLE_CLOUD_PROJECT. Allow jar path to be specified (e.g. if using non-standard image). Add missing documentation for Helm parameters.
Yanson
requested review from
davidheryanto,
khorshuheng,
pradithya,
woop and
zhilingc
as code owners
|
Hi @Yanson. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @davidheryanto |
|
Thanks @Yanson! I believe @davidheryanto wants to move from @davidheryanto can we make a decision on which to use here? |
|
I'm ok with using either StatsD exporter. Although it seems
But I think it's OK since we can put the Thanks for the PR. |
|
Just to be clear, Internally we use a "vanilla-service" chart that can deploy almost anything, so used that to deploy statsd-exporter. If you would rather have a dependency than keep the chart in this repo (which is sensible), I can share details of its use (it is already public). Regarding telegraf, I don't know much about it, bt my opinion is to stick to standard Beam metrics. Though, this discussion is outside the scope of this PR (which does not preclude such changes down the road). The other changes are more "interesting". |
|
/ok-to-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop, Yanson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Move prometheus-statsd-exporter to toggleable core dependency (default false). Add ingresses for gRPC and HTTP for both core and serving. Refactor ConfigMaps to user Spring profiles rather than manipulating the base application.yaml. Add ability to define and enable arbitrary Spring profiles. Add toggle to enable prometheus scraping in core. Add parameters to change LOG_LEVEL and LOG_TYPE (feast-dev#430). Add parameter to specify GOOGLE_CLOUD_PROJECT. Allow jar path to be specified (e.g. if using non-standard image). Add missing documentation for Helm parameters.
Move prometheus-statsd-exporter to toggleable core dependency (default false). Add ingresses for gRPC and HTTP for both core and serving. Refactor ConfigMaps to user Spring profiles rather than manipulating the base application.yaml. Add ability to define and enable arbitrary Spring profiles. Add toggle to enable prometheus scraping in core. Add parameters to change LOG_LEVEL and LOG_TYPE (#430). Add parameter to specify GOOGLE_CLOUD_PROJECT. Allow jar path to be specified (e.g. if using non-standard image). Add missing documentation for Helm parameters.
4 participants
What this PR does / why we need it:
Which issue(s) this PR fixes:
General improvements that we have had use-cases for. Please ask if the reason for any of the changes are unclear.
Does this PR introduce a user-facing change?:
To compare the Helm output of these changes with the previous version, these commands can be used.