Fix e2e batch test in v0.3-branch#412
Merged
feast-ci-bot merged 1 commit intofeast-dev:v0.3-branchfrom Jan 7, 2020
Merged
Conversation
Otherwise ingested data will not be processed because Beam job is not ready
davidheryanto
requested review from
pradithya,
thirteen37,
tims,
woop and
zhilingc
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
Member
|
I don't think I can /lgtm, but thanks for looking into the issue! |
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some new end to end tests that were added to v0.3-branch from master are missing wait after running
feast apply. Feast needs to wait for Beam job to be ready after runningfeast apply, otherwise the ingested data will not be processed by the Beam job.