Define maven revision property when packaging jars in Dockerfile so the images are built successfully#410
Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom Jan 6, 2020
Conversation
davidheryanto
requested review from
khorshuheng,
pradithya,
woop and
zhilingc
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Collaborator
|
/approve |
ches
pushed a commit
to agoda-com/feast
that referenced
this pull request
May 23, 2020
feast-ci-bot
pushed a commit
that referenced
this pull request
May 23, 2020
* Add Java code coverage reporting with JaCoCo * Define revision property when packaging jars in Dockerfile (#410) Co-authored-by: David Heryanto <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds back
-Drevision=$REVISIONargument in the Dockerfiles because without it Docker build will fail because subsequent steps assumes revision property is set.