Skip to content

Update sync helm chart script to ensure requirements.lock in in sync with requirements.yaml#373

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
davidheryanto:fix-sync-helm-charts-requirements-lock
Dec 18, 2019
Merged

Update sync helm chart script to ensure requirements.lock in in sync with requirements.yaml#373
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
davidheryanto:fix-sync-helm-charts-requirements-lock

Conversation

@davidheryanto
Copy link
Copy Markdown
Collaborator

@davidheryanto davidheryanto commented Dec 18, 2019

Running helm dep update will make sure requirements.lock is in sync with requirements.yaml, so that helm dep build runs successfully.

This script is used in automated Helm charts release.

Reference: helm/helm#2033

To ensure requirements.lock is in sync with requirements.yaml
helm/helm#2033
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Dec 18, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit 7571ba7 into feast-dev:master Dec 18, 2019
@davidheryanto davidheryanto deleted the fix-sync-helm-charts-requirements-lock branch December 18, 2019 06:39
davidheryanto added a commit that referenced this pull request Dec 18, 2019
To ensure requirements.lock is in sync with requirements.yaml
helm/helm#2033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants