Skip to content

fix: Update package.json to use latest npm package for ui#3264

Closed
hao-affirm wants to merge 1 commit intofeast-dev:v0.25-branchfrom
Affirm:update-package-json
Closed

fix: Update package.json to use latest npm package for ui#3264
hao-affirm wants to merge 1 commit intofeast-dev:v0.25-branchfrom
Affirm:update-package-json

Conversation

@hao-affirm
Copy link
Copy Markdown
Contributor

@hao-affirm hao-affirm commented Oct 2, 2022

Signed-off-by: hao-affirm [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@hao-affirm hao-affirm requested a review from adchia as a code owner October 2, 2022 07:12
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Oct 2, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hao-affirm
To complete the pull request process, please assign adchia after the PR has been reviewed.
You can assign the PR to them by writing /assign @adchia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hao-affirm
Copy link
Copy Markdown
Contributor Author

hao-affirm commented Oct 2, 2022

/assign @adchia
a simple update to use latest npm version for UI

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 2, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v0.25-branch@3102b44). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             v0.25-branch    #3264   +/-   ##
===============================================
  Coverage                ?   58.26%           
===============================================
  Files                   ?      210           
  Lines                   ?    17735           
  Branches                ?        0           
===============================================
  Hits                    ?    10334           
  Misses                  ?     7401           
  Partials                ?        0
Flag Coverage Δ
unittests 58.26% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adchia
Copy link
Copy Markdown
Collaborator

adchia commented Oct 4, 2022

making a separate PR to fix this instead to ensure the release process works correctly..

@adchia
Copy link
Copy Markdown
Collaborator

adchia commented Oct 4, 2022

see #3267

@adchia adchia closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia Awaiting requested review from adchia adchia is a code owner

Assignees

@adchia adchia

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hao-affirm @feast-ci-bot @codecov-commenter @adchia