Skip to content

docs: Update quickstart.md for missing import#2986

Closed
franciscojavierarceo wants to merge 66 commits intofeast-dev:v0.22-branchfrom
franciscojavierarceo:patch-1
Closed

docs: Update quickstart.md for missing import#2986
franciscojavierarceo wants to merge 66 commits intofeast-dev:v0.22-branchfrom
franciscojavierarceo:patch-1

Conversation

@franciscojavierarceo
Copy link
Copy Markdown
Member

The quickstart is missing an import.

What this PR does / why we need it:

Just updates the quickstart notebook.

breno-costa and others added 30 commits June 29, 2022 17:11
…dabot warning (feast-dev#2887)

* Upgrade numpy version on setup.py and resolve dependabot warning

Signed-off-by: Breno Costa <[email protected]>

* Upgrade python base image from 3.7 to 3.8

Signed-off-by: Breno Costa <[email protected]>
…built are not development and the correct versions (feast-dev#2893)

* Test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflow

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflow

Signed-off-by: Kevin Zhang <[email protected]>

* Test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
* Test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflow

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflow

Signed-off-by: Kevin Zhang <[email protected]>

* Test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix protobuf pin version and add path variable

Signed-off-by: Kevin Zhang <[email protected]>

* Revert setup

Signed-off-by: Kevin Zhang <[email protected]>

* Update 3.8

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Update 3.10

Signed-off-by: Kevin Zhang <[email protected]>

* update

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Update go with grpc 1.47

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
…in keys (feast-dev#2835)

* feat: Support retrieving from multiple feature views

Signed-off-by: Yongheng Lin <[email protected]>

* group by join keys instead of feature view

Signed-off-by: Yongheng Lin <[email protected]>

* tolerate insufficient entities

Signed-off-by: Yongheng Lin <[email protected]>

* mock registry.getEntityJoinKey

Signed-off-by: Yongheng Lin <[email protected]>

* add integration test

Signed-off-by: Yongheng Lin <[email protected]>
* fix: Bump version of Guava to mitigate cve

Signed-off-by: Achal Shah <[email protected]>

* 30.1

Signed-off-by: Achal Shah <[email protected]>
* Add feature extraction logic to batch writer

Signed-off-by: Felix Wang <[email protected]>

* Enable StreamProcessor to write to both online and offline stores

Signed-off-by: Felix Wang <[email protected]>

* Fix incorrect columns error message

Signed-off-by: Felix Wang <[email protected]>

* Reorder columns in _write_to_offline_store

Signed-off-by: Felix Wang <[email protected]>

* Make _write_to_offline_store a public method

Signed-off-by: Felix Wang <[email protected]>

* Import FeatureStore correctly

Signed-off-by: Felix Wang <[email protected]>

* Remove defaults for `processing_time` and `query_timeout`

Signed-off-by: Felix Wang <[email protected]>

* Clean up `test_offline_write.py`

Signed-off-by: Felix Wang <[email protected]>

* Do not do any custom logic for double underscore columns

Signed-off-by: Felix Wang <[email protected]>

* Lint

Signed-off-by: Felix Wang <[email protected]>

* Switch entity values for all tests using push sources to not affect other tests

Signed-off-by: Felix Wang <[email protected]>
* Add feature page functionality

Signed-off-by: Daniel Kim <[email protected]>

* Add links in feature view and feature pages

Signed-off-by: Daniel Kim <[email protected]>

* Modify Feast provider test to include new Feature pages

Signed-off-by: Daniel Kim <[email protected]>

* Add initial version of test

Signed-off-by: Daniel Kim <[email protected]>

* Make some changes to test and remove feature tab functionality from ondemand FVs

Signed-off-by: Daniel Kim <[email protected]>

* Change feature link EuiLinks to EuiCustomLinks

Signed-off-by: Daniel Kim <[email protected]>

* Change other links to EuiCustomLinks

Signed-off-by: Daniel Kim <[email protected]>
* feat: Add snowflake online store

Signed-off-by: Miles Adkins <[email protected]>

* lint/format

Signed-off-by: Miles Adkins <[email protected]>

* removing missing testing env variables

Signed-off-by: Miles Adkins <[email protected]>

* test offline store first

Signed-off-by: Miles Adkins <[email protected]>

* snowflake online test fixes

Signed-off-by: Miles Adkins <[email protected]>

* format

Signed-off-by: Miles Adkins <[email protected]>

* fix snowflake testing (feast-dev#2903)

Signed-off-by: Miles Adkins <[email protected]>
…n-scoped (feast-dev#2899)

* Test to trigger registry conflicts

Signed-off-by: Felix Wang <[email protected]>

* Switch environment and associated fixtures to being function scoped

Signed-off-by: Felix Wang <[email protected]>

* Format

Signed-off-by: Felix Wang <[email protected]>

* Switch type tests to function-scoped fixtures

Signed-off-by: Felix Wang <[email protected]>

* Format

Signed-off-by: Felix Wang <[email protected]>
* Add metadata tab functionality

Signed-off-by: Daniel Kim <[email protected]>

* Undo unnecessary changes and bring back Regular FV Demo Tab

Signed-off-by: Daniel Kim <[email protected]>

* Change metadata tab to accept custom JSON file input.

Signed-off-by: Daniel Kim <[email protected]>

* Rename instances of metadata to data

Signed-off-by: Daniel Kim <[email protected]>
* feat: Add scaffolding for batch materialization engine

Signed-off-by: Achal Shah <[email protected]>

* fix tests

Signed-off-by: Achal Shah <[email protected]>

* fix tests

Signed-off-by: Achal Shah <[email protected]>

* a little better

Signed-off-by: Achal Shah <[email protected]>

* a little better

Signed-off-by: Achal Shah <[email protected]>

* docs

Signed-off-by: Achal Shah <[email protected]>

* more api updates'

Signed-off-by: Achal Shah <[email protected]>

* fix typos

Signed-off-by: Achal Shah <[email protected]>

* make engine importable

Signed-off-by: Achal Shah <[email protected]>

* style stuff

Signed-off-by: Achal Shah <[email protected]>

* style stuff

Signed-off-by: Achal Shah <[email protected]>
…east-dev#2915)

* chore: Refactor StreamFeatureViewMeta to FeatureViewMeta and deduplicate code

Signed-off-by: Achal Shah <[email protected]>

* ttl_duration

Signed-off-by: Achal Shah <[email protected]>

* nits

Signed-off-by: Achal Shah <[email protected]>
* Delete unnecessary unit test

Signed-off-by: Felix Wang <[email protected]>

* Clean up python feature server test

Signed-off-by: Felix Wang <[email protected]>

* Clean up push source offline retrieval test

Signed-off-by: Felix Wang <[email protected]>

* Clean up push source online retrieval test

Signed-off-by: Felix Wang <[email protected]>

* Clean up offline write tests

Signed-off-by: Felix Wang <[email protected]>

* Add back reorder columns test for offline write

Signed-off-by: Felix Wang <[email protected]>

* Rename create_dataset

Signed-off-by: Felix Wang <[email protected]>

* Add SFV back into online retrieval test

Signed-off-by: Felix Wang <[email protected]>
* feat: Add to_remote_storage method to RetrievalJob

Signed-off-by: Achal Shah <[email protected]>

* docstring

Signed-off-by: Achal Shah <[email protected]>
…t-dev#2918)

* chore: Implement to_remote_storage for RedshiftRetrievalJob

Signed-off-by: Achal Shah <[email protected]>

* Implement to_remote_storage for BigQuery

Signed-off-by: Achal Shah <[email protected]>

* add for snowflake as well

Signed-off-by: Achal Shah <[email protected]>

* fully fleshed for snowflake

Signed-off-by: Achal Shah <[email protected]>

* better test config
:

Signed-off-by: Achal Shah <[email protected]>

* fix tests:

Signed-off-by: Achal Shah <[email protected]>

* fix tests

Signed-off-by: Achal Shah <[email protected]>

* more fixes

Signed-off-by: Achal Shah <[email protected]>

* more fixes

Signed-off-by: Achal Shah <[email protected]>

* more fixes

Signed-off-by: Achal Shah <[email protected]>

* fix bigquery

Signed-off-by: Achal Shah <[email protected]>

* use temp table for entity df table

Signed-off-by: Achal Shah <[email protected]>

* simplify condition

Signed-off-by: Achal Shah <[email protected]>

* remove temp

Signed-off-by: Achal Shah <[email protected]>
…v#2924)

chore: Update Feast UI dependency

Signed-off-by: Danny Chiao <[email protected]>
chore(deps): bump moment from 2.29.2 to 2.29.4 in /ui

Bumps [moment](https://github.com/moment/moment) from 2.29.2 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.2...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…garbage collection (feast-dev#2919)

* Temp fix

Signed-off-by: Kevin Zhang <[email protected]>

* Temp fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* add dynamic linking flags

Signed-off-by: Kevin Zhang <[email protected]>

* Update gitignore

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflows

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
…st-dev#2932)

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
* Update docs

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
* Remove 3.7 wheels

Signed-off-by: Kevin Zhang <[email protected]>

* ci: Add a nightly CI job for integration tests

Signed-off-by: Achal Shah <[email protected]>

* Update and rebase

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

Co-authored-by: Kevin Zhang <[email protected]>
Fix small type in README file

Signed-off-by: Hai Nguyen <[email protected]>
* Remove 3.7 wheels

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
felixwang9817 and others added 15 commits July 21, 2022 16:14
Add Go option to `feast serve` command

Signed-off-by: Felix Wang <[email protected]>
…rs (feast-dev#2964)

* chore: Fix test asserts for offline store write and improve some error messages

Signed-off-by: Achal Shah <[email protected]>

* wait for write to finish

Signed-off-by: Achal Shah <[email protected]>

* wait for write to finish

Signed-off-by: Achal Shah <[email protected]>

* detailed error messages

Signed-off-by: Achal Shah <[email protected]>

* sort and reset index

Signed-off-by: Achal Shah <[email protected]>

* fix

Signed-off-by: Achal Shah <[email protected]>
Add separate `go_feature_serving` flag to distinguish between Go feature serving and embedded Go code

Signed-off-by: Felix Wang <[email protected]>
* Update docs

Signed-off-by: Kevin Zhang <[email protected]>

* address review

Signed-off-by: Kevin Zhang <[email protected]>

* Address review

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fux

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
* Docs

Signed-off-by: Felix Wang <[email protected]>

* Update production docs

Signed-off-by: Felix Wang <[email protected]>

* Update page name

Signed-off-by: Felix Wang <[email protected]>

* Update roadmap

Signed-off-by: Felix Wang <[email protected]>
…rder (feast-dev#2735)

fix: Fixing the return order of elements when calculating the min and max entity-DF event timestamps in the Spark offline store.

Signed-off-by: Lev Pickovsky <[email protected]>
* Rename feast-python-server helm chart to feast-feature-server

Signed-off-by: Felix Wang <[email protected]>

* Switch example to Python 3.8

Signed-off-by: Felix Wang <[email protected]>

* Update helm chart docs

Signed-off-by: Felix Wang <[email protected]>

* Change name

Signed-off-by: Felix Wang <[email protected]>

* Change references

Signed-off-by: Felix Wang <[email protected]>

* Change another reference

Signed-off-by: Felix Wang <[email protected]>

* Add arrow C++ library to example Dockerfile

Signed-off-by: Felix Wang <[email protected]>
…v#2970)

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* see if fix works

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>
* 1. fix: spark source support table with pattern "db.table" (feast-dev#2605 feast-dev#2605)

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

Co-authored-by: leonpeng <kfiring>
Co-authored-by: Kevin Zhang <[email protected]>
…t-dev#2971)

* Add new test for historical retrieval with feature views with no ttl

Signed-off-by: Felix Wang <[email protected]>

* Fix no ttl logic

Signed-off-by: Felix Wang <[email protected]>
Switch log string to use regex

Signed-off-by: Felix Wang <[email protected]>
…2984)

* ci: Fix pip install issues from grpcio version mismatches

Signed-off-by: Danny Chiao <[email protected]>

* fix verify-wheel

Signed-off-by: Danny Chiao <[email protected]>

* fix verify-wheel

Signed-off-by: Danny Chiao <[email protected]>
…dev#2975)

* Refactor go feature server

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* Fix e2e tests

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Verify tests

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* Address review

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Address review

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* address review

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Refactor

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fx lit

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>

* update fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Revert

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix lint

Signed-off-by: Kevin Zhang <[email protected]>
* GitBook: [#3] docs: update intro documentation page

Signed-off-by: Danny Chiao <[email protected]>

* update main README blurb

Signed-off-by: Danny Chiao <[email protected]>

* address comments

Signed-off-by: Danny Chiao <[email protected]>
* feat: Add snowflake online store

Signed-off-by: Miles Adkins <[email protected]>

* lint/format

Signed-off-by: Miles Adkins <[email protected]>

* removing missing testing env variables

Signed-off-by: Miles Adkins <[email protected]>

* test offline store first

Signed-off-by: Miles Adkins <[email protected]>

* snowflake online test fixes

Signed-off-by: Miles Adkins <[email protected]>

* format

Signed-off-by: Miles Adkins <[email protected]>

* fix snowflake testing (feast-dev#2903)

Signed-off-by: Miles Adkins <[email protected]>

* change to transient table

Signed-off-by: Miles Adkins <[email protected]>

* remove extra lines

Signed-off-by: Miles Adkins <[email protected]>

* docs + nits

Signed-off-by: Miles Adkins <[email protected]>

* docs + nits2

Signed-off-by: Miles Adkins <[email protected]>

* final docs + nits

Signed-off-by: Miles Adkins <[email protected]>

* Update sdk/python/feast/infra/online_stores/snowflake.py

Co-authored-by: Achal Shah <[email protected]>
Signed-off-by: Miles Adkins <[email protected]>

* Update sdk/python/feast/infra/online_stores/snowflake.py

Co-authored-by: Achal Shah <[email protected]>
Signed-off-by: Miles Adkins <[email protected]>

* Update sdk/python/feast/infra/online_stores/snowflake.py

Co-authored-by: Achal Shah <[email protected]>
Signed-off-by: Miles Adkins <[email protected]>

* Update sdk/python/feast/infra/online_stores/snowflake.py

Co-authored-by: Achal Shah <[email protected]>
Signed-off-by: Miles Adkins <[email protected]>

* fix serialization

Signed-off-by: Miles Adkins <[email protected]>

* fix serialization2

Signed-off-by: Miles Adkins <[email protected]>

Co-authored-by: Achal Shah <[email protected]>
@franciscojavierarceo franciscojavierarceo changed the title Update quickstart.md for missing import docs: Update quickstart.md for missing import Jul 31, 2022
@achals
Copy link
Copy Markdown
Member

achals commented Jul 31, 2022

/ok-to-test
/lgtm

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2986 (1867c3c) into v0.22-branch (798c7b5) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v0.22-branch    #2986   +/-   ##
=============================================
  Coverage         58.08%   58.08%           
=============================================
  Files               178      178           
  Lines             15807    15807           
=============================================
  Hits               9181     9181           
  Misses             6626     6626           
Flag Coverage Δ
unittests 58.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798c7b5...1867c3c. Read the comment docs.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 31, 2022
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: franciscojavierarceo
To complete the pull request process, please assign achals after the PR has been reviewed.
You can assign the PR to them by writing /assign @achals in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@franciscojavierarceo
Copy link
Copy Markdown
Member Author

Closing this PR in favor of #2987 since I didn't haver a signed commit on this one and it looks like I pulled other changes into this one inadvertantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.