Skip to content

chore: Verification workflow in build wheels that ensures the wheels built are not development and the correct versions#2893

Merged
feast-ci-bot merged 23 commits intofeast-dev:masterfrom
kevjumba:verification_workflow
Jun 30, 2022
Merged

chore: Verification workflow in build wheels that ensures the wheels built are not development and the correct versions#2893
feast-ci-bot merged 23 commits intofeast-dev:masterfrom
kevjumba:verification_workflow

Conversation

@kevjumba
Copy link
Copy Markdown
Collaborator

@kevjumba kevjumba commented Jun 29, 2022

What this PR does / why we need it:
Hit a bunch of issues in 0.22.0 release, one of which is the fact that we did not catch that the build caused dirty git state that caused the wheels that were built to be dev wheels. This check in verify-python-wheel fixes that.
Which issue(s) this PR fixes:

Fixes #

kevjumba added 22 commits June 29, 2022 13:42
@kevjumba
Test
40eaea6 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
a33fdfd 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
933b330 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix workflow
7b43272 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix workflow
7a3c569 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Test
299cd23 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
49fa7e1 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
a84fbde 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
8b8ac51 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
c26f4dc 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
test
b005958 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
5b4f6e3 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
4f7abd7 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
1f78fd3 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
514ddd0 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
00b20f9 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
test
3abd6b7 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Merge pull request #20 from kevjumba/verification_workflow
39fd3dc 
Verification workflow
@kevjumba
Fix
2c4b22a 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
81e7b6c 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
e8f7c09 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba
Fix
839277c 
Signed-off-by: Kevin Zhang <[email protected]>
@kevjumba kevjumba requested a review from achals June 29, 2022 22:43
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 29, 2022 •
edited
Loading

Codecov Report

Merging #2893 (2047380) into master (bdf170f) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2893      +/-   ##
==========================================
- Coverage   80.68%   80.62%   -0.06%     
==========================================
  Files         176      176              
  Lines       15670    15670              
==========================================
- Hits        12643    12634       -9     
- Misses       3027     3036       +9
Flag Coverage Δ
integrationtests 70.78% <ø> (-0.13%) ⬇️
unittests 59.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.39% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf170f...2047380. Read the comment docs.

achals
achals reviewed Jun 30, 2022
View reviewed changes
.github/workflows/build_wheels.yml Outdated
VERSION_OUTPUT=$(feast version)
VERSION=$(echo $VERSION_OUTPUT | grep -oE "$VERSION_REGEX")
OUTPUT=$(echo $VERSION_OUTPUT | grep -E "$REGEX")
if [ "VERSION_WITHOUT_PREFIX" = "erification_workflow" ]; then
Copy link
Copy Markdown
Member

@achals achals Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would this be the case?

Copy link
Copy Markdown
Collaborator Author

@kevjumba kevjumba Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, leftover

@kevjumba
Fix
2047380 
Signed-off-by: Kevin Zhang <[email protected]>
achals
achals approved these changes Jun 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 8e2a375 into feast-dev:master Jun 30, 2022
adchia pushed a commit that referenced this pull request Jul 14, 2022
@kevjumba @adchia
chore: Verification workflow in build wheels that ensures the wheels …
aef9505 
…built are not development and the correct versions (#2893)

* Test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflow

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflow

Signed-off-by: Kevin Zhang <[email protected]>

* Test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
kevjumba added a commit that referenced this pull request Jul 19, 2022
@kevjumba
chore: Verification workflow in build wheels that ensures the wheels …
a5f68bf 
…built are not development and the correct versions (#2893)

* Test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflow

Signed-off-by: Kevin Zhang <[email protected]>

* Fix workflow

Signed-off-by: Kevin Zhang <[email protected]>

* Test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* test

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevjumba @codecov-commenter @feast-ci-bot @achals