Skip to content

fix: Revert "feat: Enable stream feature view materialization (#2798)"#2806

Merged
achals merged 1 commit intofeast-dev:masterfrom
felixwang9817:revert_sfv_materialization
Jun 16, 2022
Merged

fix: Revert "feat: Enable stream feature view materialization (#2798)"#2806
achals merged 1 commit intofeast-dev:masterfrom
felixwang9817:revert_sfv_materialization

Conversation

@felixwang9817
Copy link
Copy Markdown
Collaborator

This reverts commit a06700d.

What this PR does / why we need it: This PR reverts #2798, which passed but causes tests to be extremely flaky, and is therefore currently blocking other PRs. I will take a closer look at #2798 and rewrite the testing logic so we can avoid causing more test flakiness.

Which issue(s) this PR fixes:

Fixes #

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Copy Markdown
Member

achals commented Jun 16, 2022

/lgtm

@felixwang9817 felixwang9817 force-pushed the revert_sfv_materialization branch from 6690ccc to 26e016e Compare June 16, 2022 22:54
@feast-ci-bot feast-ci-bot removed the lgtm label Jun 16, 2022
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #2806 (26e016e) into master (a06700d) will decrease coverage by 0.05%.
The diff coverage is 43.33%.

@@            Coverage Diff             @@
##           master    #2806      +/-   ##
==========================================
- Coverage   59.67%   59.62%   -0.06%     
==========================================
  Files         172      173       +1     
  Lines       15311    15271      -40     
==========================================
- Hits         9137     9105      -32     
+ Misses       6174     6166       -8     
Flag Coverage Δ
unittests 59.62% <43.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/inference.py 68.60% <ø> (ø)
sdk/python/feast/registry.py 69.33% <ø> (+1.51%) ⬆️
...tegration/feature_repos/universal/feature_views.py 35.13% <0.00%> (ø)
.../integration/online_store/test_universal_online.py 17.43% <0.00%> (+0.17%) ⬆️
sdk/python/tests/unit/test_feature_views.py 98.36% <ø> (-0.33%) ⬇️
...ion/registration/test_stream_feature_view_apply.py 23.52% <7.31%> (-5.32%) ⬇️
sdk/python/feast/feature_store.py 68.91% <42.10%> (-0.02%) ⬇️
sdk/python/feast/stream_feature_view.py 88.03% <100.00%> (-1.52%) ⬇️
sdk/python/tests/unit/test_feature_view.py 100.00% <100.00%> (ø)
sdk/python/feast/version.py 60.00% <0.00%> (-20.00%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06700d...26e016e. Read the comment docs.

@achals achals merged commit 1808e06 into feast-dev:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants