Remove unused tensorflow-metadata proto files #2058
Closed
achals wants to merge 2 commits intofeast-dev:masterfrom
Closed
Remove unused tensorflow-metadata proto files #2058achals wants to merge 2 commits intofeast-dev:masterfrom
achals wants to merge 2 commits intofeast-dev:masterfrom
Conversation
Signed-off-by: Achal Shah <[email protected]>
achals
requested review from
a team,
adchia,
felixwang9817,
tsotnet and
woop
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
feast-ci-bot
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Signed-off-by: Achal Shah <[email protected]>
Member
Author
|
Turns out we have a hard dependency on the tensorflow protos in CoreService.proto, so we can't get rid of the protos themselves without removing the dependency in CoreService (or getting rid of that service entirely). I'm going to trash this PR. |
This was referenced Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
The tensorflow-metadata package was added in #2038, but the corresponding proto files were left behind so the python feels keep getting regenerated.
Also this PR adds detailed error messages for test_univerisal_e2e failures which I suspect are flaky.
Does this PR introduce a user-facing change?: